Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2024-11-25 23:00:15 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

CGDebugInfo: Instead of uniquing RetainedTypes, just refrain from retaining

Browse Source 
them more than once. (NFC)

llvm-svn: 246231
This commit is contained in:
Adrian Prantl 2015-08-27 22:56:46 +00:00
parent 02b7b56af8
commit 3a884fa9e3
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
clang/lib/CodeGen/CGDebugInfo.cpp
View File

@ -1407,6 +1407,12 @@ llvm::DIType *CGDebugInfo::getOrCreateStandaloneType(QualType D,
assert(!D.isNull() && "null type");
llvm::DIType *T = getOrCreateType(D, getOrCreateFile(Loc));
assert(T && "could not create debug info for type");
// Composite types with UIDs were already retained by DIBuilder
// because they are only referenced by name in the IR.
if (auto *CTy = dyn_cast<llvm::DICompositeType>(T))
if (!CTy->getIdentifier().empty())
return T;
RetainedTypes.push_back(D.getAsOpaquePtr());
return T;
}
@ -3367,14 +3373,9 @@ void CGDebugInfo::finalize() {
// We keep our own list of retained types, because we need to look
// up the final type in the type cache.
llvm::DenseSet<void *> UniqueTypes;
UniqueTypes.resize(RetainedTypes.size() * 2);
for (auto &RT : RetainedTypes) {
if (!UniqueTypes.insert(RT).second)
continue;
for (auto &RT : RetainedTypes)
if (auto MD = TypeCache[RT])
DBuilder.retainType(cast<llvm::DIType>(MD));
}
DBuilder.finalize();
}