From 3dcb3934c6072f5e2eed15fd63cdc1a35bb5cad4 Mon Sep 17 00:00:00 2001 From: John Thompson Date: Tue, 17 Feb 2015 20:43:47 +0000 Subject: [PATCH] Add canonical path conversion function and use it so paths are consistent. llvm-svn: 229540 --- clang-tools-extra/modularize/Modularize.cpp | 2 +- .../modularize/ModularizeUtilities.cpp | 17 ++++++++++++++++- .../modularize/ModularizeUtilities.h | 11 +++++++++++ 3 files changed, 28 insertions(+), 2 deletions(-) diff --git a/clang-tools-extra/modularize/Modularize.cpp b/clang-tools-extra/modularize/Modularize.cpp index 9d91557fb0d3..dc317c4f124f 100644 --- a/clang-tools-extra/modularize/Modularize.cpp +++ b/clang-tools-extra/modularize/Modularize.cpp @@ -239,7 +239,7 @@ std::string findInputFile(const CommandLineArguments &CLArgs) { Opts->ParseArgs(Argv.data(), Argv.data() + Argv.size(), MissingArgIndex, MissingArgCount, IncludedFlagsBitmask)); std::vector Inputs = Args->getAllArgValues(OPT_INPUT); - return Inputs.back(); + return ModularizeUtilities::getCanonicalPath(Inputs.back()); } // This arguments adjuster inserts "-include (file)" arguments for header diff --git a/clang-tools-extra/modularize/ModularizeUtilities.cpp b/clang-tools-extra/modularize/ModularizeUtilities.cpp index 14c9f5d27561..d3c48c9f1365 100644 --- a/clang-tools-extra/modularize/ModularizeUtilities.cpp +++ b/clang-tools-extra/modularize/ModularizeUtilities.cpp @@ -114,11 +114,26 @@ std::error_code ModularizeUtilities::loadSingleHeaderListsAndDependencies( llvm::sys::path::append(Dependent, DependentsList[Index]); } llvm::sys::path::native(Dependent); - Dependents.push_back(Dependent.str()); + Dependents.push_back(getCanonicalPath(Dependent.str())); } + // Get canonical form. + HeaderFileName = getCanonicalPath(HeaderFileName); // Save the resulting header file path and dependencies. HeaderFileNames.push_back(HeaderFileName.str()); Dependencies[HeaderFileName.str()] = Dependents; } return std::error_code(); } + +// Convert header path to canonical form. +// The canonical form is basically just use forward slashes, and remove "./". +// \param FilePath The file path, relative to the module map directory. +// \returns The file path in canonical form. +std::string ModularizeUtilities::getCanonicalPath(StringRef FilePath) { + std::string Tmp(FilePath); + std::replace(Tmp.begin(), Tmp.end(), '\\', '/'); + StringRef Tmp2(Tmp); + if (Tmp2.startswith("./")) + Tmp = Tmp2.substr(2); + return Tmp; +} diff --git a/clang-tools-extra/modularize/ModularizeUtilities.h b/clang-tools-extra/modularize/ModularizeUtilities.h index 3cf24fd13858..aac79d2fd9d3 100644 --- a/clang-tools-extra/modularize/ModularizeUtilities.h +++ b/clang-tools-extra/modularize/ModularizeUtilities.h @@ -67,6 +67,17 @@ protected: /// \returns std::error_code. std::error_code loadSingleHeaderListsAndDependencies( llvm::StringRef InputPath); + +public: + + // Utility functions. + + /// Convert header path to canonical form. + /// The canonical form is basically just use forward slashes, + /// and remove "./". + /// \param FilePath The file path. + /// \returns The file path in canonical form. + static std::string getCanonicalPath(llvm::StringRef FilePath); }; } // end namespace Modularize