From 41cecba8e987107c5d8ca4cfb0affde7b4d371a2 Mon Sep 17 00:00:00 2001 From: "David L. Jones" Date: Fri, 13 Jan 2017 21:02:41 +0000 Subject: [PATCH] "Use" lambda captures which are otherwise only used in asserts. NFC Summary: The LLVM coding standards recommend "using" values that are only needed by asserts: http://llvm.org/docs/CodingStandards.html#assert-liberally Without this change, LLVM cannot bootstrap with -Werror as the second stage fails with this new warning: https://reviews.llvm.org/rL291905 See also the previous fixes: https://reviews.llvm.org/rL291916 https://reviews.llvm.org/rL291939 https://reviews.llvm.org/rL291940 https://reviews.llvm.org/rL291941 Reviewers: rsmith Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D28695 llvm-svn: 291957 --- llvm/lib/Target/Hexagon/HexagonBitSimplify.cpp | 1 + llvm/lib/Transforms/Scalar/SROA.cpp | 1 + llvm/lib/Transforms/Utils/ValueMapper.cpp | 1 + 3 files changed, 3 insertions(+) diff --git a/llvm/lib/Target/Hexagon/HexagonBitSimplify.cpp b/llvm/lib/Target/Hexagon/HexagonBitSimplify.cpp index ef0f18b39f9e..063aaa7af3da 100644 --- a/llvm/lib/Target/Hexagon/HexagonBitSimplify.cpp +++ b/llvm/lib/Target/Hexagon/HexagonBitSimplify.cpp @@ -896,6 +896,7 @@ const TargetRegisterClass *HexagonBitSimplify::getFinalVRegClass( *MRI.getTargetRegisterInfo()); auto VerifySR = [&HRI] (const TargetRegisterClass *RC, unsigned Sub) -> void { + (void)HRI; assert(Sub == HRI.getHexagonSubRegIndex(RC, Hexagon::ps_sub_lo) || Sub == HRI.getHexagonSubRegIndex(RC, Hexagon::ps_sub_hi)); }; diff --git a/llvm/lib/Transforms/Scalar/SROA.cpp b/llvm/lib/Transforms/Scalar/SROA.cpp index bfcb15530ef5..4b1dad4f61ff 100644 --- a/llvm/lib/Transforms/Scalar/SROA.cpp +++ b/llvm/lib/Transforms/Scalar/SROA.cpp @@ -1825,6 +1825,7 @@ static VectorType *isVectorPromotionViable(Partition &P, const DataLayout &DL) { // Rank the remaining candidate vector types. This is easy because we know // they're all integer vectors. We sort by ascending number of elements. auto RankVectorTypes = [&DL](VectorType *RHSTy, VectorType *LHSTy) { + (void)DL; assert(DL.getTypeSizeInBits(RHSTy) == DL.getTypeSizeInBits(LHSTy) && "Cannot have vector types of different sizes!"); assert(RHSTy->getElementType()->isIntegerTy() && diff --git a/llvm/lib/Transforms/Utils/ValueMapper.cpp b/llvm/lib/Transforms/Utils/ValueMapper.cpp index 0e9baaf8649d..f77c10b6dd47 100644 --- a/llvm/lib/Transforms/Utils/ValueMapper.cpp +++ b/llvm/lib/Transforms/Utils/ValueMapper.cpp @@ -681,6 +681,7 @@ void MDNodeMapper::mapNodesInPOT(UniquedGraph &G) { remapOperands(*ClonedN, [this, &D, &G](Metadata *Old) { if (Optional MappedOp = getMappedOp(Old)) return *MappedOp; + (void)D; assert(G.Info[Old].ID > D.ID && "Expected a forward reference"); return &G.getFwdReference(*cast(Old)); });