Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2025-02-26 13:26:22 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[ELF] Avoid std::stable_partition which may allocate memory. NFC

Browse Source
This commit is contained in:
Fangrui Song 2021-11-28 21:47:55 -08:00
parent 99a2d940dd
commit 4709bacf18
1 changed files with 13 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
lld/ELF/Writer.cpp
View File

@ -1836,18 +1836,22 @@ static void removeUnusedSyntheticSections() {
})
.base();
// Mark unused synthetic sections for deletion
auto end = std::stable_partition(start, inputSections.end(),
[&](InputSectionBase *s) {
auto *sec = cast<SyntheticSection>(s);
return sec->getParent() && sec->isNeeded();
});
// Remove unused synthetic sections from inputSections;
DenseSet<InputSectionBase *> unused;
auto end =
std::remove_if(start, inputSections.end(), [&](InputSectionBase *s) {
auto *sec = cast<SyntheticSection>(s);
if (sec->getParent() && sec->isNeeded())
return false;
unused.insert(sec);
return true;
});
inputSections.erase(end, inputSections.end());
// Remove unused synthetic sections from the corresponding input section
// description and orphanSections.
DenseSet<InputSectionBase *> unused(end, inputSections.end());
for (auto it = end; it != inputSections.end(); ++it)
if (OutputSection *osec = cast<SyntheticSection>(*it)->getParent())
for (auto *sec : unused)
if (OutputSection *osec = cast<SyntheticSection>(sec)->getParent())
for (SectionCommand *cmd : osec->commands)
if (auto *isd = dyn_cast<InputSectionDescription>(cmd))
llvm::erase_if(isd->sections, [&](InputSection *isec) {
@ -1856,9 +1860,6 @@ static void removeUnusedSyntheticSections() {
llvm::erase_if(script->orphanSections, [&](const InputSectionBase *sec) {
return unused.count(sec);
});
// Erase unused synthetic sections.
inputSections.erase(end, inputSections.end());
}
// Create output section objects and add them to OutputSections.