diff --git a/clang/include/clang/Parse/Parser.h b/clang/include/clang/Parse/Parser.h index d9014b6a77c3..4071172743a1 100644 --- a/clang/include/clang/Parse/Parser.h +++ b/clang/include/clang/Parse/Parser.h @@ -397,7 +397,8 @@ private: DeclTy *ParseCXXInlineMethodDef(AccessSpecifier AS, Declarator &D); void ParseLexedMethodDefs(); - bool ConsumeAndStoreUntil(tok::TokenKind T, TokensTy &Toks); + bool ConsumeAndStoreUntil(tok::TokenKind T, TokensTy &Toks, + tok::TokenKind EarlyAbortIf = tok::unknown); //===--------------------------------------------------------------------===// // C99 6.9: External Definitions. diff --git a/clang/lib/Parse/ParseCXXInlineMethods.cpp b/clang/lib/Parse/ParseCXXInlineMethods.cpp index 7d977c1251b0..2f5014ba5040 100644 --- a/clang/lib/Parse/ParseCXXInlineMethods.cpp +++ b/clang/lib/Parse/ParseCXXInlineMethods.cpp @@ -11,6 +11,7 @@ // //===----------------------------------------------------------------------===// +#include "clang/Basic/Diagnostic.h" #include "clang/Parse/Parser.h" #include "clang/Parse/DeclSpec.h" #include "clang/Parse/Scope.h" @@ -36,7 +37,19 @@ Parser::ParseCXXInlineMethodDef(AccessSpecifier AS, Declarator &D) { // We may have a constructor initializer here. if (Tok.is(tok::colon)) { // Consume everything up to (and including) the left brace. - ConsumeAndStoreUntil(tok::l_brace, Toks); + if (!ConsumeAndStoreUntil(tok::l_brace, Toks, tok::semi)) { + // We didn't find the left-brace we expected after the + // constructor initializer. + if (Tok.is(tok::semi)) { + // We found a semicolon; complain, consume the semicolon, and + // don't try to parse this method later. + Diag(Tok.getLocation(), diag::err_expected_lbrace); + ConsumeAnyToken(); + getCurTopClassStack().pop(); + return FnD; + } + } + } else { // Begin by storing the '{' token. Toks.push_back(Tok); @@ -82,9 +95,12 @@ void Parser::ParseLexedMethodDefs() { /// ConsumeAndStoreUntil - Consume and store the token at the passed token /// container until the token 'T' is reached (which gets consumed/stored too). +/// If EarlyAbortIf is specified, then we will stop early if we find that +/// token at the top level. /// Returns true if token 'T' was found. /// NOTE: This is a specialized version of Parser::SkipUntil. -bool Parser::ConsumeAndStoreUntil(tok::TokenKind T, TokensTy &Toks) { +bool Parser::ConsumeAndStoreUntil(tok::TokenKind T, TokensTy &Toks, + tok::TokenKind EarlyAbortIf) { // We always want this function to consume at least one token if the first // token isn't T and if not at EOF. bool isFirstTokenConsumed = true; @@ -96,6 +112,10 @@ bool Parser::ConsumeAndStoreUntil(tok::TokenKind T, TokensTy &Toks) { return true; } + // If we found the early-abort token, return. + if (Tok.is(EarlyAbortIf)) + return false; + switch (Tok.getKind()) { case tok::eof: // Ran out of tokens. diff --git a/clang/test/SemaCXX/constructor-initializer.cpp b/clang/test/SemaCXX/constructor-initializer.cpp index 6b450b097ac7..a79b6caac983 100644 --- a/clang/test/SemaCXX/constructor-initializer.cpp +++ b/clang/test/SemaCXX/constructor-initializer.cpp @@ -41,3 +41,7 @@ public: { } }; + +class G : A { + G() : A(10); // expected-error{{expected '{'}} +};