Reorganize locale extension fallbacks. NFCI

The various _l locale extension functions originate from very
different places.  Some come from POSIX, some are BSD extensions,
and some are shared BSD and GLIBC extensions. This patch tries to
group the local extension reimplementations by source. This should
make it easier to make libcxx work with POSIX compliant C libraries
that lack these extensions.

The fallback locale functions are also useful on their own for other
lightweight platforms. Putting these fallback implementations in
support/xlocale should enable code sharing.

I have no access to a newlib system or an android system to build
and test with. I _do_ have access to a system without any of the _l
locale extensions though, and I was able to ensure that the new
__posix_l_fallback.h and __strtonum_fallback.h didn't have any massive
problems.

http://reviews.llvm.org/D17416

llvm-svn: 270213
This commit is contained in:
Ben Craig 2016-05-20 12:58:41 +00:00
parent 4fa8250ad0
commit 57b8b1f75f
5 changed files with 225 additions and 207 deletions

View File

@ -24,8 +24,8 @@ extern "C" {
}
#endif
// Share implementation with Newlib
#include <support/xlocale/xlocale.h>
#include <support/xlocale/__posix_l_fallback.h>
#include <support/xlocale/__strtonum_fallback.h>
#endif // defined(__ANDROID__)
#endif // _LIBCPP_SUPPORT_ANDROID_LOCALE_BIONIC_H

View File

@ -17,17 +17,8 @@
#include <cwctype>
#include <ctype.h>
#include <support/xlocale/__nop_locale_mgmt.h>
#ifdef __cplusplus
extern "C" {
#endif
// Share implementation with Android's Bionic
#include <support/xlocale/xlocale.h>
#ifdef __cplusplus
} // extern "C"
#endif
#include <support/xlocale/__posix_l_fallback.h>
#include <support/xlocale/__strtonum_fallback.h>
#endif // _NEWLIB_VERSION

View File

@ -0,0 +1,165 @@
// -*- C++ -*-
//===--------------- support/xlocale/__posix_l_fallback.h -----------------===//
//
// The LLVM Compiler Infrastructure
//
// This file is dual licensed under the MIT and the University of Illinois Open
// Source Licenses. See LICENSE.TXT for details.
//
//===----------------------------------------------------------------------===//
// These are reimplementations of some extended locale functions ( *_l ) that
// are normally part of POSIX. This shared implementation provides parts of the
// extended locale support for libc's that normally don't have any (like
// Android's bionic and Newlib).
//===----------------------------------------------------------------------===//
#ifndef _LIBCPP_SUPPORT_XLOCALE_POSIX_L_FALLBACK_H
#define _LIBCPP_SUPPORT_XLOCALE_POSIX_L_FALLBACK_H
#ifdef __cplusplus
extern "C" {
#endif
inline _LIBCPP_ALWAYS_INLINE int isalnum_l(int c, locale_t) {
return ::isalnum(c);
}
inline _LIBCPP_ALWAYS_INLINE int isalpha_l(int c, locale_t) {
return ::isalpha(c);
}
inline _LIBCPP_ALWAYS_INLINE int isblank_l(int c, locale_t) {
return ::isblank(c);
}
inline _LIBCPP_ALWAYS_INLINE int iscntrl_l(int c, locale_t) {
return ::iscntrl(c);
}
inline _LIBCPP_ALWAYS_INLINE int isdigit_l(int c, locale_t) {
return ::isdigit(c);
}
inline _LIBCPP_ALWAYS_INLINE int isgraph_l(int c, locale_t) {
return ::isgraph(c);
}
inline _LIBCPP_ALWAYS_INLINE int islower_l(int c, locale_t) {
return ::islower(c);
}
inline _LIBCPP_ALWAYS_INLINE int isprint_l(int c, locale_t) {
return ::isprint(c);
}
inline _LIBCPP_ALWAYS_INLINE int ispunct_l(int c, locale_t) {
return ::ispunct(c);
}
inline _LIBCPP_ALWAYS_INLINE int isspace_l(int c, locale_t) {
return ::isspace(c);
}
inline _LIBCPP_ALWAYS_INLINE int isupper_l(int c, locale_t) {
return ::isupper(c);
}
inline _LIBCPP_ALWAYS_INLINE int isxdigit_l(int c, locale_t) {
return ::isxdigit(c);
}
inline _LIBCPP_ALWAYS_INLINE int iswalnum_l(wint_t c, locale_t) {
return ::iswalnum(c);
}
inline _LIBCPP_ALWAYS_INLINE int iswalpha_l(wint_t c, locale_t) {
return ::iswalpha(c);
}
inline _LIBCPP_ALWAYS_INLINE int iswblank_l(wint_t c, locale_t) {
return ::iswblank(c);
}
inline _LIBCPP_ALWAYS_INLINE int iswcntrl_l(wint_t c, locale_t) {
return ::iswcntrl(c);
}
inline _LIBCPP_ALWAYS_INLINE int iswdigit_l(wint_t c, locale_t) {
return ::iswdigit(c);
}
inline _LIBCPP_ALWAYS_INLINE int iswgraph_l(wint_t c, locale_t) {
return ::iswgraph(c);
}
inline _LIBCPP_ALWAYS_INLINE int iswlower_l(wint_t c, locale_t) {
return ::iswlower(c);
}
inline _LIBCPP_ALWAYS_INLINE int iswprint_l(wint_t c, locale_t) {
return ::iswprint(c);
}
inline _LIBCPP_ALWAYS_INLINE int iswpunct_l(wint_t c, locale_t) {
return ::iswpunct(c);
}
inline _LIBCPP_ALWAYS_INLINE int iswspace_l(wint_t c, locale_t) {
return ::iswspace(c);
}
inline _LIBCPP_ALWAYS_INLINE int iswupper_l(wint_t c, locale_t) {
return ::iswupper(c);
}
inline _LIBCPP_ALWAYS_INLINE int iswxdigit_l(wint_t c, locale_t) {
return ::iswxdigit(c);
}
inline _LIBCPP_ALWAYS_INLINE int toupper_l(int c, locale_t) {
return ::toupper(c);
}
inline _LIBCPP_ALWAYS_INLINE int tolower_l(int c, locale_t) {
return ::tolower(c);
}
inline _LIBCPP_ALWAYS_INLINE int towupper_l(int c, locale_t) {
return ::towupper(c);
}
inline _LIBCPP_ALWAYS_INLINE int towlower_l(int c, locale_t) {
return ::towlower(c);
}
inline _LIBCPP_ALWAYS_INLINE int strcoll_l(const char *s1, const char *s2,
locale_t) {
return ::strcoll(s1, s2);
}
inline _LIBCPP_ALWAYS_INLINE size_t strxfrm_l(char *dest, const char *src,
size_t n, locale_t) {
return ::strxfrm(dest, src, n);
}
inline _LIBCPP_ALWAYS_INLINE size_t strftime_l(char *s, size_t max,
const char *format,
const struct tm *tm, locale_t) {
return ::strftime(s, max, format, tm);
}
inline _LIBCPP_ALWAYS_INLINE int wcscoll_l(const wchar_t *ws1,
const wchar_t *ws2, locale_t) {
return ::wcscoll(ws1, ws2);
}
inline _LIBCPP_ALWAYS_INLINE size_t wcsxfrm_l(wchar_t *dest, const wchar_t *src,
size_t n, locale_t) {
return ::wcsxfrm(dest, src, n);
}
#ifdef __cplusplus
}
#endif
#endif // _LIBCPP_SUPPORT_XLOCALE_POSIX_L_FALLBACK_H

View File

@ -0,0 +1,56 @@
// -*- C++ -*-
//===-------------- support/xlocale/__strtonum_fallback.h -----------------===//
//
// The LLVM Compiler Infrastructure
//
// This file is dual licensed under the MIT and the University of Illinois Open
// Source Licenses. See LICENSE.TXT for details.
//
//===----------------------------------------------------------------------===//
// These are reimplementations of some extended locale functions ( *_l ) that
// aren't part of POSIX. They are widely available though (GLIBC, BSD, maybe
// others). The unifying aspect in this case is that all of these functions
// convert strings to some numeric type.
//===----------------------------------------------------------------------===//
#ifndef _LIBCPP_SUPPORT_XLOCALE_STRTONUM_FALLBACK_H
#define _LIBCPP_SUPPORT_XLOCALE_STRTONUM_FALLBACK_H
#ifdef __cplusplus
extern "C" {
#endif
inline _LIBCPP_ALWAYS_INLINE long double strtold_l(const char *nptr,
char **endptr, locale_t) {
return ::strtold(nptr, endptr);
}
inline _LIBCPP_ALWAYS_INLINE long long
strtoll_l(const char *nptr, char **endptr, int base, locale_t) {
return ::strtoll(nptr, endptr, base);
}
inline _LIBCPP_ALWAYS_INLINE unsigned long long
strtoull_l(const char *nptr, char **endptr, int base, locale_t) {
return ::strtoull(nptr, endptr, base);
}
inline _LIBCPP_ALWAYS_INLINE long long
wcstoll_l(const wchar_t *nptr, wchar_t **endptr, int base, locale_t) {
return ::wcstoll(nptr, endptr, base);
}
inline _LIBCPP_ALWAYS_INLINE unsigned long long
wcstoull_l(const wchar_t *nptr, wchar_t **endptr, int base, locale_t) {
return ::wcstoull(nptr, endptr, base);
}
inline _LIBCPP_ALWAYS_INLINE long double wcstold_l(const wchar_t *nptr,
wchar_t **endptr, locale_t) {
return ::wcstold(nptr, endptr);
}
#ifdef __cplusplus
}
#endif
#endif // _LIBCPP_SUPPORT_XLOCALE_STRTONUM_FALLBACK_H

View File

@ -1,194 +0,0 @@
// -*- C++ -*-
//===------------------- support/xlocale/xlocale.h ------------------------===//
//
// The LLVM Compiler Infrastructure
//
// This file is dual licensed under the MIT and the University of Illinois Open
// Source Licenses. See LICENSE.TXT for details.
//
//===----------------------------------------------------------------------===//
// This is a shared implementation of a shim to provide extended locale support
// on top of libc's that don't support it (like Android's bionic, and Newlib).
//
// The 'illusion' only works when the specified locale is "C" or "POSIX", but
// that's about as good as we can do without implementing full xlocale support
// in the underlying libc.
//===----------------------------------------------------------------------===//
#ifndef _LIBCPP_SUPPORT_XLOCALE_XLOCALE_H
#define _LIBCPP_SUPPORT_XLOCALE_XLOCALE_H
#ifdef __cplusplus
extern "C" {
#endif
static inline int isalnum_l(int c, locale_t) {
return isalnum(c);
}
static inline int isalpha_l(int c, locale_t) {
return isalpha(c);
}
static inline int isblank_l(int c, locale_t) {
return isblank(c);
}
static inline int iscntrl_l(int c, locale_t) {
return iscntrl(c);
}
static inline int isdigit_l(int c, locale_t) {
return isdigit(c);
}
static inline int isgraph_l(int c, locale_t) {
return isgraph(c);
}
static inline int islower_l(int c, locale_t) {
return islower(c);
}
static inline int isprint_l(int c, locale_t) {
return isprint(c);
}
static inline int ispunct_l(int c, locale_t) {
return ispunct(c);
}
static inline int isspace_l(int c, locale_t) {
return isspace(c);
}
static inline int isupper_l(int c, locale_t) {
return isupper(c);
}
static inline int isxdigit_l(int c, locale_t) {
return isxdigit(c);
}
static inline int iswalnum_l(wint_t c, locale_t) {
return iswalnum(c);
}
static inline int iswalpha_l(wint_t c, locale_t) {
return iswalpha(c);
}
static inline int iswblank_l(wint_t c, locale_t) {
return iswblank(c);
}
static inline int iswcntrl_l(wint_t c, locale_t) {
return iswcntrl(c);
}
static inline int iswdigit_l(wint_t c, locale_t) {
return iswdigit(c);
}
static inline int iswgraph_l(wint_t c, locale_t) {
return iswgraph(c);
}
static inline int iswlower_l(wint_t c, locale_t) {
return iswlower(c);
}
static inline int iswprint_l(wint_t c, locale_t) {
return iswprint(c);
}
static inline int iswpunct_l(wint_t c, locale_t) {
return iswpunct(c);
}
static inline int iswspace_l(wint_t c, locale_t) {
return iswspace(c);
}
static inline int iswupper_l(wint_t c, locale_t) {
return iswupper(c);
}
static inline int iswxdigit_l(wint_t c, locale_t) {
return iswxdigit(c);
}
static inline int toupper_l(int c, locale_t) {
return toupper(c);
}
static inline int tolower_l(int c, locale_t) {
return tolower(c);
}
static inline int towupper_l(int c, locale_t) {
return towupper(c);
}
static inline int towlower_l(int c, locale_t) {
return towlower(c);
}
static inline int strcoll_l(const char *s1, const char *s2, locale_t) {
return strcoll(s1, s2);
}
static inline size_t strxfrm_l(char *dest, const char *src, size_t n,
locale_t) {
return strxfrm(dest, src, n);
}
static inline size_t strftime_l(char *s, size_t max, const char *format,
const struct tm *tm, locale_t) {
return strftime(s, max, format, tm);
}
static inline int wcscoll_l(const wchar_t *ws1, const wchar_t *ws2, locale_t) {
return wcscoll(ws1, ws2);
}
static inline size_t wcsxfrm_l(wchar_t *dest, const wchar_t *src, size_t n,
locale_t) {
return wcsxfrm(dest, src, n);
}
static inline long double strtold_l(const char *nptr, char **endptr, locale_t) {
return strtold(nptr, endptr);
}
static inline long long strtoll_l(const char *nptr, char **endptr, int base,
locale_t) {
return strtoll(nptr, endptr, base);
}
static inline unsigned long long strtoull_l(const char *nptr, char **endptr,
int base, locale_t) {
return strtoull(nptr, endptr, base);
}
static inline long long wcstoll_l(const wchar_t *nptr, wchar_t **endptr,
int base, locale_t) {
return wcstoll(nptr, endptr, base);
}
static inline unsigned long long wcstoull_l(const wchar_t *nptr,
wchar_t **endptr, int base,
locale_t) {
return wcstoull(nptr, endptr, base);
}
static inline long double wcstold_l(const wchar_t *nptr, wchar_t **endptr,
locale_t) {
return wcstold(nptr, endptr);
}
#ifdef __cplusplus
}
#endif
#endif // _LIBCPP_SUPPORT_XLOCALE_XLOCALE_H