Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2024-12-26 01:39:11 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[clang-tidy] Fix PR35824

Browse Source 
Differential Revision: https://reviews.llvm.org/D46027
This commit is contained in:
Gabor Horvath 2019-11-27 10:56:36 -08:00
parent b98a0c7f6c
commit 5c5e860535
2 changed files with 33 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
clang-tools-extra/clang-tidy/bugprone/SuspiciousSemicolonCheck.cpp
View File

@ -20,7 +20,8 @@ namespace bugprone {
void SuspiciousSemicolonCheck::registerMatchers(MatchFinder *Finder) {
Finder->addMatcher(
stmt(anyOf(ifStmt(hasThen(nullStmt().bind("semi")),
unless(hasElse(stmt()))),
unless(hasElse(stmt())),
unless(isConstexpr())),
forStmt(hasBody(nullStmt().bind("semi"))),
cxxForRangeStmt(hasBody(nullStmt().bind("semi"))),
whileStmt(hasBody(nullStmt().bind("semi")))))

31
clang-tools-extra/test/clang-tidy/bugprone-suspicious-semicolon-constexpr.cpp Normal file
View File

@ -0,0 +1,31 @@
// RUN: %check_clang_tidy %s bugprone-suspicious-semicolon %t -- -- -std=c++17
void fail()
{
int x = 0;
if(x > 5); (void)x;
// CHECK-MESSAGES: :[[@LINE-1]]:12: warning: potentially unintended semicolon [bugprone-suspicious-semicolon]
// CHECK-FIXES: if(x > 5) (void)x;
}
template <int X>
int foo(int a) {
if constexpr(X > 0) {
return a;
}
return a + 1;
}
template <int X>
int foo2(int a) {
// FIXME: diagnose the case below. See https://reviews.llvm.org/D46234
// for details.
if constexpr(X > 0);
return a;
return a + 1;
}
int main(void) {
foo2<0>(1);
return foo<0>(1);
}