Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2025-02-20 10:07:02 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[Sema] -Wformat: recognize %lb for the printf/scanf family of functions

Browse Source 
Fix https://github.com/llvm/llvm-project/issues/62247

D131057 added `bArg` and `BArg` in the `AsLongLong` label in
`FormatSpecifier::hasValidLengthModifier`, but missed the `AsLong` label,
therefore `%llb` is allowed while `%lb` (e.g. `printf("%lb", (long)10)`) has a
spurious warning. Add the missing case labels.

Reviewed By: aaron.ballman, enh

Differential Revision: https://reviews.llvm.org/D148779
This commit is contained in:
Fangrui Song 2023-04-20 09:34:34 -07:00
parent 3b0677964c
commit 5cf37d8bd5
4 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
clang/docs/ReleaseNotes.rst
View File

@ -228,6 +228,9 @@ Improvements to Clang's diagnostics
- Clang's "static assertion failed" diagnostic now points to the static assertion
expression instead of pointing to the ``static_assert`` token.
(`#61951 <https://github.com/llvm/llvm-project/issues/61951>`_)
- ``-Wformat`` now recognizes ``%lb`` for the ``printf``/``scanf`` family of
functions.
(`#62247: <https://github.com/llvm/llvm-project/issues/62247>`_).
Bug Fixes in This Version
-------------------------

2
clang/lib/AST/FormatString.cpp
View File

@ -848,6 +848,8 @@ bool FormatSpecifier::hasValidLengthModifier(const TargetInfo &Target,
}
switch (CS.getKind()) {
case ConversionSpecifier::bArg:
case ConversionSpecifier::BArg:
case ConversionSpecifier::dArg:
case ConversionSpecifier::DArg:
case ConversionSpecifier::iArg:

6
clang/test/Sema/format-strings-fixit.c
View File

@ -22,6 +22,7 @@ void test(void) {
printf("abc%0f", "testing testing 123");
printf("%u", (long) -12);
printf("%b", (long) -13);
printf("%d", (long) -14);
printf("%p", 123);
printf("%c\n", "x");
printf("%c\n", 1.23);
@ -162,6 +163,7 @@ void test2(int intSAParm[static 2]) {
// Preserve the original formatting.
scanf("%b", &longVar);
scanf("%d", &longVar);
scanf("%o", &longVar);
scanf("%u", &longVar);
scanf("%x", &longVar);
@ -181,7 +183,8 @@ void test2(int intSAParm[static 2]) {
// CHECK: printf("%d", (int) 123);
// CHECK: printf("abc%s", "testing testing 123");
// CHECK: printf("%ld", (long) -12);
// CHECK: printf("%ld", (long) -13);
// CHECK: printf("%lb", (long) -13);
// CHECK: printf("%ld", (long) -14);
// CHECK: printf("%d", 123);
// CHECK: printf("%s\n", "x");
// CHECK: printf("%f\n", 1.23);
@ -249,6 +252,7 @@ void test2(int intSAParm[static 2]) {
// CHECK: scanf("%ju", (my_uintmax_type*)&uIntmaxVar);
// CHECK: scanf("%td", (my_ptrdiff_type*)&ptrdiffVar);
// CHECK: scanf("%d", (my_int_type*)&intVar);
// CHECK: scanf("%lb", &longVar);
// CHECK: scanf("%ld", &longVar);
// CHECK: scanf("%lo", &longVar);
// CHECK: scanf("%lu", &longVar);

1
clang/test/Sema/format-strings.c
View File

@ -304,6 +304,7 @@ void test10(int x, float f, int i, long long lli) {
printf("%qp", (void *)0); // expected-warning{{length modifier 'q' results in undefined behavior or no effect with 'p' conversion specifier}}
printf("hhX %hhX", (unsigned char)10); // no-warning
printf("llX %llX", (long long) 10); // no-warning
printf("%lb %lB", (long) 10, (long) 10); // no-warning
printf("%llb %llB", (long long) 10, (long long) 10); // no-warning
// This is fine, because there is an implicit conversion to an int.
printf("%d", (unsigned char) 10); // no-warning