Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2025-01-05 23:52:45 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[Module] Respect -fno-pch-timestamps when building modules

Browse Source 
Always respect the FrontendOption to not include timestamps in PCH or
Modules when `-fno-pch-timestamps` is specified.

Reviewed By: benlangmuir

Differential Revision: https://reviews.llvm.org/D141632
This commit is contained in:
Steven Wu 2023-02-01 10:34:05 -08:00
parent ca174f12c4
commit 5cff68fca0
2 changed files with 32 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
clang/lib/Frontend/FrontendActions.cpp
View File

@ -202,7 +202,8 @@ GenerateModuleAction::CreateASTConsumer(CompilerInstance &CI,
/*AllowASTWithErrors=*/
+CI.getFrontendOpts().AllowPCMWithCompilerErrors,
/*IncludeTimestamps=*/
+CI.getFrontendOpts().BuildingImplicitModule,
+CI.getFrontendOpts().BuildingImplicitModule &&
+CI.getFrontendOpts().IncludeTimestamps,
/*ShouldCacheASTInMemory=*/
+CI.getFrontendOpts().BuildingImplicitModule));
Consumers.push_back(CI.getPCHContainerWriter().CreatePCHContainerGenerator(

30
clang/test/Modules/timestamps.c Normal file
View File

@ -0,0 +1,30 @@
/// Verify timestamps that gets embedded in the module
#include <c-header.h>
// RUN: rm -rf %t
// RUN: %clang_cc1 -fmodules -fimplicit-module-maps -fdisable-module-hash \
// RUN: -fmodules-cache-path=%t -I %S/Inputs %s
// RUN: cp %t/c_library.pcm %t1.pcm
// RUN: llvm-bcanalyzer --dump --disable-histogram %t1.pcm > %t1.dump
// RUN: FileCheck %s --check-prefix=CHECK --check-prefix=TIMESTAMP --input-file %t1.dump
// RUN: rm -rf %t
// RUN: %clang_cc1 -fmodules -fimplicit-module-maps -fdisable-module-hash \
// RUN: -fmodules-cache-path=%t -I %S/Inputs -fno-pch-timestamp %s
// RUN: cp %t/c_library.pcm %t2.pcm
// RUN: llvm-bcanalyzer --dump --disable-histogram %t2.pcm > %t2.dump
// RUN: FileCheck %s --check-prefix=CHECK --check-prefix=NOTIMESTAMP --input-file %t2.dump
// RUN: not diff %t1.dump %t2.dump
// CHECK: <INPUT_FILES_BLOCK NumWords=[[#]] BlockCodeSize=[[#]]>
// CHECK-NEXT: <INPUT_FILE abbrevid=4 op0=1 op1=[[#]]
// TIMESTAMP-NOT: op2=0
// NOTIMESTAMP: op2=0
// CHECK-SAME: blob data = 'module.map'
// CHECK-NEXT: <INPUT_FILE_HASH abbrevid=[[#]] op0=[[#]] op1=[[#]]/>
// CHECK-NEXT: <INPUT_FILE abbrevid=4 op0=2 op1=[[#]]
// TIMESTAMP-NOT: op2=0
// NOTIMESTAMP: op2=0
// CHECK-SAME: blob data = 'c-header.h'
// CHECK-NEXT: <INPUT_FILE_HASH abbrevid=[[#]] op0=[[#]] op1=[[#]]/>
// CHECK-NEXT: </INPUT_FILES_BLOCK>