Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2024-10-08 20:04:02 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[darwin] switch blocking mutex from osspinlock to os_unfair_lock

Browse Source 
OSSpinLock is deprecated, so we are switching to `os_unfair_lock`. However, `os_unfair_lock` isn't available on older OSs, so we keep `OSSpinLock` as fallback.

Also change runtime assumption check to static since they only ever check constant values.

rdar://69588111

Reviewed By: delcypher, yln

Differential Revision: https://reviews.llvm.org/D97509
This commit is contained in:
Emily Shi 2021-02-25 16:04:29 -08:00
parent 8f9f7d02aa
commit 71ef54337d
1 changed files with 26 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
compiler-rt/lib/sanitizer_common/sanitizer_mac.cpp
View File

@ -70,6 +70,7 @@ extern "C" {
#include <mach/mach_time.h>
#include <mach/vm_statistics.h>
#include <malloc/malloc.h>
#include <os/lock.h>
#include <os/log.h>
#include <pthread.h>
#include <sched.h>
@ -506,22 +507,42 @@ void MprotectMallocZones(void *addr, int prot) {
}
BlockingMutex::BlockingMutex() {
// Initialize all member variables to 0
internal_memset(this, 0, sizeof(*this));
static_assert(sizeof(os_unfair_lock_t) <= sizeof(opaque_storage_),
"Not enough space in opaque storage to use os_unfair_lock");
static_assert(sizeof(OSSpinLock) <= sizeof(opaque_storage_),
"Not enough space in opaque storage to use OSSpinLock");
}
static bool UnfairLockAvailable() { return bool(os_unfair_lock_lock); }
static_assert(OS_UNFAIR_LOCK_INIT._os_unfair_lock_opaque == 0,
"os_unfair_lock does not initialize to 0");
static_assert(OS_SPINLOCK_INIT == 0, "OSSpinLock does not initialize to 0");
void BlockingMutex::Lock() {
CHECK(sizeof(OSSpinLock) <= sizeof(opaque_storage_));
CHECK_EQ(OS_SPINLOCK_INIT, 0);
CHECK_EQ(owner_, 0);
OSSpinLockLock((OSSpinLock*)&opaque_storage_);
if (UnfairLockAvailable()) {
os_unfair_lock_lock((os_unfair_lock *)&opaque_storage_);
} else {
OSSpinLockLock((OSSpinLock *)&opaque_storage_);
}
}
void BlockingMutex::Unlock() {
OSSpinLockUnlock((OSSpinLock*)&opaque_storage_);
if (UnfairLockAvailable()) {
os_unfair_lock_unlock((os_unfair_lock *)&opaque_storage_);
} else {
OSSpinLockUnlock((OSSpinLock *)&opaque_storage_);
}
}
void BlockingMutex::CheckLocked() {
CHECK_NE(*(OSSpinLock*)&opaque_storage_, 0);
if (UnfairLockAvailable()) {
CHECK_NE((*(os_unfair_lock *)&opaque_storage_)._os_unfair_lock_opaque, 0);
} else {
CHECK_NE(*(OSSpinLock *)&opaque_storage_, 0);
}
}
u64 NanoTime() {