Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2024-12-22 23:39:24 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[lldb] Remove 'use_synthetic' parameters in ValueObject code

Browse Source 
Summary:
`CalculateSyntheticValue` and `GetSyntheticValue` have a `use_synthetic` parameter
that makes the function do nothing when it's false. We obviously always pass true
to the function (or check that the value we pass is true), because there really isn't
any point calling with function with a `false`. This just removes all of this.

Reviewers: labath, JDevlieghere, davide

Reviewed By: davide

Subscribers: davide

Differential Revision: https://reviews.llvm.org/D79568
This commit is contained in:
Raphael Isemann 2020-05-08 19:09:30 +02:00
parent adf3b8e366
commit 7b1f1cf1cf
4 changed files with 9 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lldb/include/lldb/Core/ValueObject.h
View File

@ -575,7 +575,7 @@ public:
virtual lldb::ValueObjectSP GetNonSyntheticValue();
lldb::ValueObjectSP GetSyntheticValue(bool use_synthetic = true);
lldb::ValueObjectSP GetSyntheticValue();
virtual bool HasSyntheticValue();
@ -926,7 +926,7 @@ protected:
virtual bool HasDynamicValueTypeInfo() { return false; }
virtual void CalculateSyntheticValue(bool use_synthetic = true);
virtual void CalculateSyntheticValue();
// Should only be called by ValueObject::GetChildAtIndex() Returns a
// ValueObject managed by this ValueObject's manager.

2
lldb/include/lldb/Core/ValueObjectSyntheticFilter.h
View File

@ -66,7 +66,7 @@ public:
bool IsSynthetic() override { return true; }
void CalculateSyntheticValue(bool use_synthetic) override {}
void CalculateSyntheticValue() override {}
bool IsDynamic() override {
return ((m_parent != nullptr) ? m_parent->IsDynamic() : false);

2
lldb/source/API/SBValue.cpp
View File

@ -137,7 +137,7 @@ public:
}
if (m_use_synthetic) {
ValueObjectSP synthetic_sp = value_sp->GetSyntheticValue(m_use_synthetic);
ValueObjectSP synthetic_sp = value_sp->GetSyntheticValue();
if (synthetic_sp)
value_sp = synthetic_sp;
}

16
lldb/source/Core/ValueObject.cpp
View File

@ -1933,10 +1933,7 @@ ValueObject::GetSyntheticExpressionPathChild(const char *expression,
return synthetic_child_sp;
}
void ValueObject::CalculateSyntheticValue(bool use_synthetic) {
if (!use_synthetic)
return;
void ValueObject::CalculateSyntheticValue() {
TargetSP target_sp(GetTargetSP());
if (target_sp && !target_sp->GetEnableSyntheticValue()) {
m_synthetic_value = nullptr;
@ -1988,11 +1985,8 @@ ValueObjectSP ValueObject::GetStaticValue() { return GetSP(); }
lldb::ValueObjectSP ValueObject::GetNonSyntheticValue() { return GetSP(); }
ValueObjectSP ValueObject::GetSyntheticValue(bool use_synthetic) {
if (!use_synthetic)
return ValueObjectSP();
CalculateSyntheticValue(use_synthetic);
ValueObjectSP ValueObject::GetSyntheticValue() {
CalculateSyntheticValue();
if (m_synthetic_value)
return m_synthetic_value->GetSP();
@ -2006,7 +2000,7 @@ bool ValueObject::HasSyntheticValue() {
if (m_synthetic_children_sp.get() == nullptr)
return false;
CalculateSyntheticValue(true);
CalculateSyntheticValue();
return m_synthetic_value != nullptr;
}
@ -3341,7 +3335,7 @@ lldb::ValueObjectSP ValueObjectManager::GetSP() {
}
if (m_use_synthetic) {
lldb::ValueObjectSP synthetic_sp = m_user_valobj_sp->GetSyntheticValue(m_use_synthetic);
lldb::ValueObjectSP synthetic_sp = m_user_valobj_sp->GetSyntheticValue();
if (synthetic_sp)
m_user_valobj_sp = synthetic_sp;
}