From 7cca34acc4acd9d163ca8b9e585587b8897483b9 Mon Sep 17 00:00:00 2001 From: Tobias Hieta Date: Tue, 8 Feb 2022 09:26:09 +0100 Subject: [PATCH] [llvm-rc]: Find -clang over just clang This patch makes llvm-rc/windres prefer -clang over clang when doing it's preprocessing. This is so that we can have a .cfg file for and configure sysroot and other important flags. Config files not picked up with clang --target= automatically. We only look for -clang in the same dir as llvm-windres and not for all PATHs to minimize the change. Reviewed By: mstorsjo Differential Revision: https://reviews.llvm.org/D119219 --- llvm/tools/llvm-rc/llvm-rc.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/llvm/tools/llvm-rc/llvm-rc.cpp b/llvm/tools/llvm-rc/llvm-rc.cpp index d43994deecc0..b6d204706134 100644 --- a/llvm/tools/llvm-rc/llvm-rc.cpp +++ b/llvm/tools/llvm-rc/llvm-rc.cpp @@ -124,13 +124,14 @@ std::string createTempFile(const Twine &Prefix, StringRef Suffix) { return static_cast(FileName); } -ErrorOr findClang(const char *Argv0) { +ErrorOr findClang(const char *Argv0, StringRef Triple) { StringRef Parent = llvm::sys::path::parent_path(Argv0); ErrorOr Path = std::error_code(); + std::string TargetClang = (Triple + "-clang").str(); if (!Parent.empty()) { // First look for the tool with all potential names in the specific // directory of Argv0, if known - for (const auto *Name : {"clang", "clang-cl"}) { + for (const auto *Name : {TargetClang.c_str(), "clang", "clang-cl"}) { Path = sys::findProgramByName(Name, Parent); if (Path) return Path; @@ -219,7 +220,7 @@ bool preprocess(StringRef Src, StringRef Dst, const RcOptions &Opts, if (Opts.PrintCmdAndExit) { Clang = "clang"; } else { - ErrorOr ClangOrErr = findClang(Argv0); + ErrorOr ClangOrErr = findClang(Argv0, Opts.Triple); if (ClangOrErr) { Clang = *ClangOrErr; } else {