Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2024-11-28 08:02:08 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[BOLT][Wrapper] Fix off-by-one when parsing 'cmp' output

Browse Source 
The byte offsets in the output of 'cmp' start from 1, not from 0 as the
current parser assumes. This caused mismatched bytes to sometimes be
attributed to the wrong section.

Reviewed By: rafauler

Differential Revision: https://reviews.llvm.org/D149046
This commit is contained in:
Job Noorman 2023-04-24 20:54:23 +02:00
parent 0911558005
commit 8421c7ad30
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
bolt/utils/llvm-bolt-wrapper.py
View File

@ -206,7 +206,8 @@ def parse_cmp_offset(cmp_out):
Extracts byte number from cmp output:
file1 file2 differ: byte X, line Y
'''
return int(re.search(r'byte (\d+),', cmp_out).groups()[0])
# NOTE: cmp counts bytes starting from 1!
return int(re.search(r'byte (\d+),', cmp_out).groups()[0]) - 1
def report_real_time(binary, main_err, cmp_err, cfg):
'''