diff --git a/clang/include/clang/Basic/Attr.td b/clang/include/clang/Basic/Attr.td index 3d2bebb6f6d8..fc886faab14c 100644 --- a/clang/include/clang/Basic/Attr.td +++ b/clang/include/clang/Basic/Attr.td @@ -101,6 +101,8 @@ class Attr { bit SemaHandler = 1; // Set to true for attributes that are completely ignored. bit Ignored = 0; + // Set to true if each of the spellings is a distinct attribute. + bit DistinctSpellings = 0; // Any additional text that should be included verbatim in the class. code AdditionalMembers = [{}]; } @@ -530,6 +532,7 @@ def Override : InheritableAttr { def Ownership : InheritableAttr { let Spellings = ["ownership_holds", "ownership_returns", "ownership_takes"]; + let DistinctSpellings = 1; let Args = [EnumArgument<"OwnKind", "OwnershipKind", ["ownership_holds", "ownership_returns", "ownership_takes"], ["Holds", "Returns", "Takes"]>, diff --git a/clang/lib/Sema/SemaDeclAttr.cpp b/clang/lib/Sema/SemaDeclAttr.cpp index 284a72e3399b..93516501aace 100644 --- a/clang/lib/Sema/SemaDeclAttr.cpp +++ b/clang/lib/Sema/SemaDeclAttr.cpp @@ -3792,7 +3792,6 @@ static void ProcessInheritableDeclAttr(Sema &S, Scope *scope, Decl *D, // by ProcessNonInheritableDeclAttr. break; case AttributeList::AT_alias: handleAliasAttr (S, D, Attr); break; - case AttributeList::AT_align: case AttributeList::AT_aligned: handleAlignedAttr (S, D, Attr); break; case AttributeList::AT_always_inline: handleAlwaysInlineAttr (S, D, Attr); break; diff --git a/clang/utils/TableGen/ClangAttrEmitter.cpp b/clang/utils/TableGen/ClangAttrEmitter.cpp index 4177660e26b9..772fc2f526f4 100644 --- a/clang/utils/TableGen/ClangAttrEmitter.cpp +++ b/clang/utils/TableGen/ClangAttrEmitter.cpp @@ -1062,7 +1062,8 @@ void ClangAttrParsedAttrListEmitter::run(raw_ostream &OS) { Record &Attr = **I; bool SemaHandler = Attr.getValueAsBit("SemaHandler"); - + bool DistinctSpellings = Attr.getValueAsBit("DistinctSpellings"); + if (SemaHandler) { std::vector Spellings = getValueAsListOfStrings(Attr, "Spellings"); @@ -1079,6 +1080,9 @@ void ClangAttrParsedAttrListEmitter::run(raw_ostream &OS) { ProcessedAttrs.insert(AttrName); OS << "PARSED_ATTR(" << AttrName << ")\n"; + + if (!DistinctSpellings) + break; } } } @@ -1097,23 +1101,23 @@ void ClangAttrParsedAttrKindsEmitter::run(raw_ostream &OS) { bool SemaHandler = Attr.getValueAsBit("SemaHandler"); bool Ignored = Attr.getValueAsBit("Ignored"); - + bool DistinctSpellings = Attr.getValueAsBit("DistinctSpellings"); if (SemaHandler || Ignored) { std::vector Spellings = getValueAsListOfStrings(Attr, "Spellings"); for (std::vector::const_iterator I = Spellings.begin(), E = Spellings.end(); I != E; ++I) { - StringRef AttrName = *I, Spelling = *I; - - AttrName = NormalizeAttrName(AttrName); - Spelling = NormalizeAttrSpelling(Spelling); + StringRef AttrName = NormalizeAttrName(DistinctSpellings + ? *I + : Spellings.front()); + StringRef Spelling = NormalizeAttrSpelling(*I); if (SemaHandler) Matches.push_back( - StringMatcher::StringPair(Spelling, - std::string("return AttributeList::AT_") + - AttrName.str() + ";")); + StringMatcher::StringPair( + Spelling, + std::string("return AttributeList::AT_")+AttrName.str() + ";")); else Matches.push_back( StringMatcher::StringPair(