From 9146e44124907679d2b568098a0f922cf93cb3e5 Mon Sep 17 00:00:00 2001 From: Fariborz Jahanian Date: Mon, 11 Jan 2010 17:50:35 +0000 Subject: [PATCH] Fixup rewrite of ivars accessed via an explicit object in a function. Fixes radar 7522803. llvm-svn: 93159 --- clang/lib/Frontend/RewriteObjC.cpp | 5 +++-- clang/test/Rewriter/rewrite-ivar-use.m | 7 ++++++- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/clang/lib/Frontend/RewriteObjC.cpp b/clang/lib/Frontend/RewriteObjC.cpp index 3000d7760554..28f79aa10adf 100644 --- a/clang/lib/Frontend/RewriteObjC.cpp +++ b/clang/lib/Frontend/RewriteObjC.cpp @@ -1235,8 +1235,9 @@ Stmt *RewriteObjC::RewriteObjCIvarRefExpr(ObjCIvarRefExpr *IV, // Explicit ivar refs need to have a cast inserted. // FIXME: consider sharing some of this code with the code above. - if (const PointerType *pType = IV->getBase()->getType()->getAs()) { - ObjCInterfaceType *iFaceDecl = dyn_cast(pType->getPointeeType()); + if (IV->isArrow()) { + ObjCInterfaceType *iFaceDecl = + dyn_cast(BaseExpr->getType()->getPointeeType()); // lookup which class implements the instance variable. ObjCInterfaceDecl *clsDeclared = 0; iFaceDecl->getDecl()->lookupInstanceVariable(D->getIdentifier(), diff --git a/clang/test/Rewriter/rewrite-ivar-use.m b/clang/test/Rewriter/rewrite-ivar-use.m index 9d6a0fa6bb80..82cff5b2d633 100644 --- a/clang/test/Rewriter/rewrite-ivar-use.m +++ b/clang/test/Rewriter/rewrite-ivar-use.m @@ -1,4 +1,4 @@ -// RUN: %clang_cc1 -rewrite-objc %s -o - +// RUN: %clang_cc1 -rewrite-objc -fms-extensions %s -o - // radar 7490331 @interface Foo { @@ -10,6 +10,11 @@ @end @implementation Foo +// radar 7522803 +static void foo(id bar) { + int i = ((Foo *)bar)->a; +} + - (void)bar { a = 42; [self baz:b];