[driver] Address missed feedback from https://reviews.llvm.org/D158476

I missed this before I committed.
This commit is contained in:
Shoaib Meenai 2023-09-18 16:28:04 -07:00
parent 58288c6c12
commit 915ebb07df
2 changed files with 5 additions and 5 deletions

View File

@ -346,7 +346,7 @@ Android Support
- Android target triples are usually suffixed with a version. Clang searches for - Android target triples are usually suffixed with a version. Clang searches for
target-specific runtime and standard libraries in directories named after the target-specific runtime and standard libraries in directories named after the
target (e.g. if you're building with ``-target aarch64-none-linux-android21``, target (e.g. if you're building with ``--target=aarch64-none-linux-android21``,
Clang will look for ``lib/aarch64-none-linux-android21`` under its resource Clang will look for ``lib/aarch64-none-linux-android21`` under its resource
directory to find runtime libraries). If an exact match isn't found, Clang directory to find runtime libraries). If an exact match isn't found, Clang
would previously fall back to a directory without any version (which would be would previously fall back to a directory without any version (which would be

View File

@ -11,12 +11,12 @@
// RUN: mkdir -p %t/resource/lib/aarch64-none-linux-android23 // RUN: mkdir -p %t/resource/lib/aarch64-none-linux-android23
// Using an unversioned directory for an unversioned triple isn't a warning. // Using an unversioned directory for an unversioned triple isn't a warning.
// RUN: %clang -target aarch64-none-linux-android -ccc-install-dir %t/bin \ // RUN: %clang --target=aarch64-none-linux-android -ccc-install-dir %t/bin \
// RUN: -resource-dir %t/resource -### -c %s 2>&1 | \ // RUN: -resource-dir %t/resource -### -c %s 2>&1 | \
// RUN: FileCheck --check-prefix=NO-WARNING %s // RUN: FileCheck --check-prefix=NO-WARNING %s
// NO-WARNING-NOT: Using unversioned Android target directory // NO-WARNING-NOT: Using unversioned Android target directory
// RUN: %clang -target aarch64-none-linux-android21 -ccc-install-dir %t/bin \ // RUN: %clang --target=aarch64-none-linux-android21 -ccc-install-dir %t/bin \
// RUN: -resource-dir %t/resource -### -c %s 2>&1 | \ // RUN: -resource-dir %t/resource -### -c %s 2>&1 | \
// RUN: FileCheck --check-prefix=ANDROID21 -DDIR=%t -DSEP=%{fs-sep} %s // RUN: FileCheck --check-prefix=ANDROID21 -DDIR=%t -DSEP=%{fs-sep} %s
// ANDROID21-DAG: Using unversioned Android target directory [[DIR]]/bin[[SEP]]..[[SEP]]include[[SEP]]aarch64-none-linux-android // ANDROID21-DAG: Using unversioned Android target directory [[DIR]]/bin[[SEP]]..[[SEP]]include[[SEP]]aarch64-none-linux-android
@ -24,10 +24,10 @@
// ANDROID21-DAG: Using unversioned Android target directory [[DIR]]/resource[[SEP]]lib[[SEP]]aarch64-none-linux-android // ANDROID21-DAG: Using unversioned Android target directory [[DIR]]/resource[[SEP]]lib[[SEP]]aarch64-none-linux-android
// 23 or newer should use the versioned directory // 23 or newer should use the versioned directory
// RUN: %clang -target aarch64-none-linux-android23 -ccc-install-dir %t/bin \ // RUN: %clang --target=aarch64-none-linux-android23 -ccc-install-dir %t/bin \
// RUN: -resource-dir %t/resource -### -c %s 2>&1 | \ // RUN: -resource-dir %t/resource -### -c %s 2>&1 | \
// RUN: FileCheck --check-prefix=NO-WARNING %s // RUN: FileCheck --check-prefix=NO-WARNING %s
// RUN: %clang -target aarch64-none-linux-android28 -ccc-install-dir %t/bin \ // RUN: %clang --target=aarch64-none-linux-android28 -ccc-install-dir %t/bin \
// RUN: -resource-dir %t/resource -### -c %s 2>&1 | \ // RUN: -resource-dir %t/resource -### -c %s 2>&1 | \
// RUN: FileCheck --check-prefix=NO-WARNING %s // RUN: FileCheck --check-prefix=NO-WARNING %s