Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2025-02-17 16:31:02 +00:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

[libc++][ABI Break] Make is_error_condition_enum_v and is_error_code_enum_v bool, not size_t

Browse Source 
`is_error_condition_enum_v` and `is_error_code_enum_v` are currently of
type `size_t`, but the standard mandates they are of type `bool`.

This is an ABI break technically since the size of these variable
templates has changed. Document it as such in the release notes.

Fixes https://bugs.llvm.org/show_bug.cgi?id=50755

Reviewed By: ldionne, Quuxplusone, #libc, var-const

Differential Revision: https://reviews.llvm.org/D112553
This commit is contained in:
Joe Loser 2021-10-28 15:38:02 -04:00
parent a66451ebbe
commit 93df7b9f75
No known key found for this signature in database
GPG Key ID: 1CDBEBC050EA230D
4 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libcxx/docs/ReleaseNotes.rst
View File

@ -78,6 +78,12 @@ API Changes
exceeds the maximum supported size, as required by the C++ standard.
Previously the type ``std::length_error`` was used.
ABI Changes
-----------
- The C++17 variable templates ``is_error_code_enum_v`` and
``is_error_condition_enum_v`` are now of type ``bool`` instead of ``size_t``.
Build System Changes
--------------------

8
libcxx/include/system_error
View File

@ -46,10 +46,10 @@ template <class T> struct is_error_condition_enum
: public false_type {};
template <class _Tp>
inline constexpr size_t is_error_condition_enum_v = is_error_condition_enum<_Tp>::value; // C++17
inline constexpr bool is_error_condition_enum_v = is_error_condition_enum<_Tp>::value; // C++17
template <class _Tp>
inline constexpr size_t is_error_code_enum_v = is_error_code_enum<_Tp>::value; // C++17
inline constexpr bool is_error_code_enum_v = is_error_code_enum<_Tp>::value; // C++17
class error_code
{
@ -165,7 +165,7 @@ struct _LIBCPP_TEMPLATE_VIS is_error_code_enum
#if _LIBCPP_STD_VER > 14
template <class _Tp>
inline constexpr size_t is_error_code_enum_v = is_error_code_enum<_Tp>::value;
inline constexpr bool is_error_code_enum_v = is_error_code_enum<_Tp>::value;
#endif
// is_error_condition_enum
@ -176,7 +176,7 @@ struct _LIBCPP_TEMPLATE_VIS is_error_condition_enum
#if _LIBCPP_STD_VER > 14
template <class _Tp>
inline constexpr size_t is_error_condition_enum_v = is_error_condition_enum<_Tp>::value;
inline constexpr bool is_error_condition_enum_v = is_error_condition_enum<_Tp>::value;
#endif
template <>

1
libcxx/test/std/diagnostics/syserr/is_error_code_enum.pass.cpp
View File

@ -23,6 +23,7 @@ test()
static_assert((std::is_error_code_enum<T>::value == Expected), "");
#if TEST_STD_VER > 14
static_assert((std::is_error_code_enum_v<T> == Expected), "");
ASSERT_SAME_TYPE(decltype(std::is_error_code_enum_v<T>), const bool);
#endif
}

1
libcxx/test/std/diagnostics/syserr/is_error_condition_enum.pass.cpp
View File

@ -23,6 +23,7 @@ test()
static_assert((std::is_error_condition_enum<T>::value == Expected), "");
#if TEST_STD_VER > 14
static_assert((std::is_error_condition_enum_v<T> == Expected), "");
ASSERT_SAME_TYPE(decltype(std::is_error_condition_enum_v<T>), const bool);
#endif
}