Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2025-01-16 05:01:56 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[DA][NewPM] Handle transitive dependencies in the new-pm version of DA

Browse Source 
Summary:
The analysis result of DA caches pointers to AA, SCEV, and LI, but it
never checks for their invalidation. Fix that.

Reviewers: chandlerc, dmgreen, bogner

Reviewed By: dmgreen

Subscribers: hiraditya, bollu, javed.absar, llvm-commits

Differential Revision: https://reviews.llvm.org/D56381

llvm-svn: 352986
This commit is contained in:
Philip Pfaffe 2019-02-03 12:25:41 +00:00
parent 5a570dd437
commit 9438585fe4
3 changed files with 33 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
llvm/include/llvm/Analysis/DependenceAnalysis.h
View File

@ -274,6 +274,10 @@ template <typename T> class ArrayRef;
LoopInfo *LI)
: AA(AA), SE(SE), LI(LI), F(F) {}
/// Handle transitive invalidation when the cached analysis results go away.
bool invalidate(Function &F, const PreservedAnalyses &PA,
FunctionAnalysisManager::Invalidator &Inv);
/// depends - Tests for a dependence between the Src and Dst instructions.
/// Returns NULL if no dependence; otherwise, returns a Dependence (or a
/// FullDependence) with as much information as can be gleaned.

13
llvm/lib/Analysis/DependenceAnalysis.cpp
View File

@ -3368,6 +3368,19 @@ static void dumpSmallBitVector(SmallBitVector &BV) {
}
#endif
bool DependenceInfo::invalidate(Function &F, const PreservedAnalyses &PA,
FunctionAnalysisManager::Invalidator &Inv) {
// Check if the analysis itself has been invalidated.
auto PAC = PA.getChecker<DependenceAnalysis>();
if (!PAC.preserved() && !PAC.preservedSet<AllAnalysesOn<Function>>())
return true;
// Check transitive dependencies.
return Inv.invalidate<AAManager>(F, PA) ||
Inv.invalidate<ScalarEvolutionAnalysis>(F, PA) ||
Inv.invalidate<LoopAnalysis>(F, PA);
}
// depends -
// Returns NULL if there is no dependence.
// Otherwise, return a Dependence with as many details as possible.

16
llvm/test/Analysis/DependenceAnalysis/new-pm-invalidation.ll Normal file
View File

@ -0,0 +1,16 @@
; RUN: opt < %s -passes='require<da>,invalidate<scalar-evolution>,print<da>' \
; RUN: -disable-output -debug-pass-manager 2>&1 | FileCheck %s
; CHECK: Running analysis: DependenceAnalysis on test_no_noalias
; CHECK: Running analysis: ScalarEvolutionAnalysis on test_no_noalias
; CHECK: Invalidating analysis: ScalarEvolutionAnalysis on test_no_noalias
; CHECK: Invalidating analysis: DependenceAnalysis on test_no_noalias
; CHECK: Running analysis: DependenceAnalysis on test_no_noalias
; CHECK: da analyze - none!
; CHECK: da analyze - confused!
; CHECK: da analyze - none!
define void @test_no_noalias(i32* %A, i32* %B) {
store i32 1, i32* %A
store i32 2, i32* %B
ret void
}