Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2025-02-21 18:54:02 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[lldb] Unwrap the type when dereferencing the value

Browse Source 
The value type can be a typedef of a reference (e.g. `typedef int& myint`).
In this case `GetQualType(type)` will return `clang::Typedef`, which cannot
be casted to `clang::ReferenceType`.

Fix a regression introduced in https://reviews.llvm.org/D103532.

Reviewed By: teemperor

Differential Revision: https://reviews.llvm.org/D113673
This commit is contained in:
Andy Yankovsky 2021-11-11 15:39:49 +01:00
parent 2a299e4f06
commit 95102b7dc3
3 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
View File

@ -6492,7 +6492,8 @@ CompilerType TypeSystemClang::GetChildCompilerTypeAtIndex(
case clang::Type::RValueReference:
if (idx_is_valid) {
const clang::ReferenceType *reference_type =
llvm::cast<clang::ReferenceType>(GetQualType(type).getTypePtr());
llvm::cast<clang::ReferenceType>(
RemoveWrappingTypes(GetQualType(type)).getTypePtr());
CompilerType pointee_clang_type =
GetType(reference_type->getPointeeType());
if (transparent_pointers && pointee_clang_type.IsAggregateType()) {

4
lldb/test/API/lang/cpp/dereferencing_references/TestCPPDereferencingReferences.py
View File

@ -21,3 +21,7 @@ class TestCase(TestBase):
# Same as above for rvalue references.
rref_val = self.expect_var_path("r_ref", type="TTT &&")
self.assertEqual(rref_val.Dereference().GetType().GetName(), "TTT")
# Typedef to a reference should dereference to the underlying type.
td_val = self.expect_var_path("td_to_ref_type", type="td_int_ref")
self.assertEqual(td_val.Dereference().GetType().GetName(), "int")

5
lldb/test/API/lang/cpp/dereferencing_references/main.cpp
View File

@ -1,8 +1,13 @@
typedef int TTT;
typedef int &td_int_ref;
int main() {
int i = 0;
// references to typedefs
TTT &l_ref = i;
TTT &&r_ref = static_cast<TTT &&>(i);
// typedef of a reference
td_int_ref td_to_ref_type = i;
return l_ref; // break here
}