Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2025-04-03 22:02:12 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[BOLT] Check MCContext errors

Browse Source 
Abort on emission errors to prevent a malformed binary being written.
Example:
```
<unknown>:0: error: Undefined temporary symbol .Ltmp26310
<unknown>:0: error: Undefined temporary symbol .Ltmp26311
<unknown>:0: error: Undefined temporary symbol .Ltmp26312
<unknown>:0: error: Undefined temporary symbol .Ltmp26313
<unknown>:0: error: Undefined temporary symbol .Ltmp26314
<unknown>:0: error: Undefined temporary symbol .Ltmp26315
BOLT-ERROR: Emission failed.
```

Reviewed By: yota9

Differential Revision: https://reviews.llvm.org/D123263
This commit is contained in:
Amir Ayupov 2022-04-08 21:07:27 -07:00
parent 82dcf30636
commit 9b02dc631d
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
bolt/lib/Rewrite/RewriteInstance.cpp
View File

@ -3108,6 +3108,10 @@ void RewriteInstance::emitAndLink() {
emitBinaryContext(*Streamer, *BC, getOrgSecPrefix()); emitBinaryContext(*Streamer, *BC, getOrgSecPrefix());
Streamer->Finish(); Streamer->Finish();
if (Streamer->getContext().hadError()) {
errs() << "BOLT-ERROR: Emission failed.\n";
exit(1);
}
////////////////////////////////////////////////////////////////////////////// //////////////////////////////////////////////////////////////////////////////
// Assign addresses to new sections. // Assign addresses to new sections.
@ -3137,7 +3141,7 @@ void RewriteInstance::emitAndLink() {
RTDyld->finalizeWithMemoryManagerLocking(); RTDyld->finalizeWithMemoryManagerLocking();
if (RTDyld->hasError()) { if (RTDyld->hasError()) {
outs() << "BOLT-ERROR: RTDyld failed: " << RTDyld->getErrorString() << "\n"; errs() << "BOLT-ERROR: RTDyld failed: " << RTDyld->getErrorString() << "\n";
exit(1); exit(1);
} }