From a5403a3a69d10d79c1abd361f02460380e08b2c0 Mon Sep 17 00:00:00 2001 From: Petr Hosek Date: Mon, 30 Oct 2023 20:45:03 -0700 Subject: [PATCH] [libcxx] Amend XFAIL for failing tests on Windows (#70422) Some tests starting passing/failing after #69431 because Clang no longer enables -fdelayed-template-parsing by default on Windows with C++20. --- .../atomics/diagnose_invalid_memory_order.verify.cpp | 7 ++++--- libcxx/test/libcxx/fuzzing/random.pass.cpp | 4 ++++ libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp | 4 ++++ libcxx/test/std/numerics/c.math/cmath.pass.cpp | 4 ++++ 4 files changed, 16 insertions(+), 3 deletions(-) diff --git a/libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp b/libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp index a6c1160c7022..defd43cf267a 100644 --- a/libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp +++ b/libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp @@ -6,9 +6,10 @@ // //===----------------------------------------------------------------------===// -// This test fails because diagnose_if doesn't emit all of the diagnostics -// when -fdelayed-template-parsing is enabled, like it is in MSVC mode. -// XFAIL: msvc +// This test fails with Clang <18 because diagnose_if doesn't emit all of the +// diagnostics when -fdelayed-template-parsing is enabled, like it is in MSVC +// mode. +// XFAIL: msvc && (clang-16 || clang-17) // REQUIRES: diagnose-if-support diff --git a/libcxx/test/libcxx/fuzzing/random.pass.cpp b/libcxx/test/libcxx/fuzzing/random.pass.cpp index 79ab7ac41151..69b496fa3a4e 100644 --- a/libcxx/test/libcxx/fuzzing/random.pass.cpp +++ b/libcxx/test/libcxx/fuzzing/random.pass.cpp @@ -6,6 +6,10 @@ // //===----------------------------------------------------------------------===// +// This test fails because Clang no longer enables -fdelayed-template-parsing +// by default on Windows with C++20 (#69431). +// XFAIL: msvc && clang-18 + // UNSUPPORTED: c++03, c++11 #include diff --git a/libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp b/libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp index 87767a2ee431..7a6c71ae68f7 100644 --- a/libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp +++ b/libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp @@ -6,6 +6,10 @@ // //===----------------------------------------------------------------------===// +// This test fails because Clang no longer enables -fdelayed-template-parsing +// by default on Windows with C++20 (#69431). +// XFAIL: msvc && clang-18 + // #include diff --git a/libcxx/test/std/numerics/c.math/cmath.pass.cpp b/libcxx/test/std/numerics/c.math/cmath.pass.cpp index 11a3de748cb7..a6a9dad639cd 100644 --- a/libcxx/test/std/numerics/c.math/cmath.pass.cpp +++ b/libcxx/test/std/numerics/c.math/cmath.pass.cpp @@ -6,6 +6,10 @@ // //===----------------------------------------------------------------------===// +// This test fails because Clang no longer enables -fdelayed-template-parsing +// by default on Windows with C++20 (#69431). +// XFAIL: msvc && clang-18 + // #include