COFF: Move markLive() from Writer.cpp to its own file.

Conceptually, garbage collection is not part of Writer,
so move the function out of the file.

llvm-svn: 248099

lld/COFF/CMakeLists.txt

@@ -10,6 +10,7 @@ add_llvm_library(lldCOFF
   Error.cpp
   ICF.cpp
   InputFiles.cpp
+  MarkLive.cpp
   ModuleDef.cpp
   SymbolTable.cpp
   Symbols.cpp

lld/COFF/Driver.cpp

@@ -644,6 +644,14 @@ void LinkerDriver::link(llvm::ArrayRef<const char *> ArgsArr) {
   if (auto *Arg = Args.getLastArg(OPT_pdb))
     touchFile(Arg->getValue());
 
+  // Identify unreferenced COMDAT sections.
+  if (Config->DoGC)
+    markLive(Symtab.getChunks());
+
+  // Identify identical COMDAT sections to merge them.
+  if (Config->DoICF)
+    doICF(Symtab.getChunks());
+
   // Write the result.
   writeResult(&Symtab);
 

lld/COFF/Driver.h

@@ -37,6 +37,12 @@ class InputFile;
 // Entry point of the COFF linker.
 void link(llvm::ArrayRef<const char *> Args);
 
+// Implemented in MarkLive.cpp.
+void markLive(const std::vector<Chunk *> &Chunks);
+
+// Implemented in ICF.cpp.
+void doICF(const std::vector<Chunk *> &Chunks);
+
 class ArgParser {
 public:
   ArgParser() : Alloc(AllocAux) {}

lld/COFF/MarkLive.cpp

@@ -0,0 +1,61 @@
+//===- MarkLive.cpp -------------------------------------------------------===//
+//
+//                             The LLVM Linker
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+
+#include "Chunks.h"
+#include "Symbols.h"
+#include "llvm/ADT/STLExtras.h"
+#include <vector>
+
+namespace lld {
+namespace coff {
+
+// Set live bit on for each reachable chunk. Unmarked (unreachable)
+// COMDAT chunks will be ignored by Writer, so they will be excluded
+// from the final output.
+void markLive(const std::vector<Chunk *> &Chunks) {
+  // We build up a worklist of sections which have been marked as live. We only
+  // push into the worklist when we discover an unmarked section, and we mark
+  // as we push, so sections never appear twice in the list.
+  SmallVector<SectionChunk *, 256> Worklist;
+
+  // COMDAT section chunks are dead by default. Add non-COMDAT chunks.
+  for (Chunk *C : Chunks)
+    if (auto *SC = dyn_cast<SectionChunk>(C))
+      if (SC->isLive())
+        Worklist.push_back(SC);
+
+  auto Enqueue = [&](SectionChunk *C) {
+    if (C->isLive())
+      return;
+    C->markLive();
+    Worklist.push_back(C);
+  };
+
+  // Add GC root chunks.
+  for (Undefined *U : Config->GCRoot)
+    if (auto *D = dyn_cast<DefinedRegular>(U->repl()))
+      Enqueue(D->getChunk());
+
+  while (!Worklist.empty()) {
+    SectionChunk *SC = Worklist.pop_back_val();
+    assert(SC->isLive() && "We mark as live when pushing onto the worklist!");
+
+    // Mark all symbols listed in the relocation table for this section.
+    for (SymbolBody *S : SC->symbols())
+      if (auto *D = dyn_cast<DefinedRegular>(S->repl()))
+        Enqueue(D->getChunk());
+
+    // Mark associative sections if any.
+    for (SectionChunk *C : SC->children())
+      Enqueue(C);
+  }
+}
+
+}
+}

lld/COFF/Writer.cpp

@@ -49,8 +49,6 @@ public:
   void run();
 
 private:
-  void markLive();
-  void dedupCOMDATs();
   void createSections();
   void createMiscChunks();
   void createImportTables();
@@ -216,8 +214,6 @@ bool Defined::isExecutable() {
 
 // The main function of the writer.
 void Writer::run() {
-  markLive();
-  dedupCOMDATs();
   createSections();
   createMiscChunks();
   createImportTables();
@@ -239,57 +235,6 @@ void Writer::run() {
   error(Buffer->commit(), "Failed to write the output file");
 }
 
-// Set live bit on for each reachable chunk. Unmarked (unreachable)
-// COMDAT chunks will be ignored in the next step, so that they don't
-// come to the final output file.
-void Writer::markLive() {
-  if (!Config->DoGC)
-    return;
-
-  // We build up a worklist of sections which have been marked as live. We only
-  // push into the worklist when we discover an unmarked section, and we mark
-  // as we push, so sections never appear twice in the list.
-  SmallVector<SectionChunk *, 256> Worklist;
-
-  // COMDAT section chunks are dead by default. Add non-COMDAT chunks.
-  for (Chunk *C : Symtab->getChunks())
-    if (auto *SC = dyn_cast<SectionChunk>(C))
-      if (SC->isLive())
-        Worklist.push_back(SC);
-
-  auto Enqueue = [&](SectionChunk *C) {
-    if (C->isLive())
-      return;
-    C->markLive();
-    Worklist.push_back(C);
-  };
-
-  // Add GC root chunks.
-  for (Undefined *U : Config->GCRoot)
-    if (auto *D = dyn_cast<DefinedRegular>(U->repl()))
-      Enqueue(D->getChunk());
-
-  while (!Worklist.empty()) {
-    SectionChunk *SC = Worklist.pop_back_val();
-    assert(SC->isLive() && "We mark as live when pushing onto the worklist!");
-
-    // Mark all symbols listed in the relocation table for this section.
-    for (SymbolBody *S : SC->symbols())
-      if (auto *D = dyn_cast<DefinedRegular>(S->repl()))
-        Enqueue(D->getChunk());
-
-    // Mark associative sections if any.
-    for (SectionChunk *C : SC->children())
-      Enqueue(C);
-  }
-}
-
-// Merge identical COMDAT sections.
-void Writer::dedupCOMDATs() {
-  if (Config->DoICF)
-    doICF(Symtab->getChunks());
-}
-
 static StringRef getOutputSection(StringRef Name) {
   StringRef S = Name.split('$').first;
   auto It = Config->Merge.find(S);

lld/COFF/Writer.h

@@ -20,9 +20,6 @@ class OutputSection;
 
 void writeResult(SymbolTable *T);
 
-// Implemented in ICF.cpp.
-void doICF(const std::vector<Chunk *> &Chunks);
-
 }
 }