[libc] Mark operator== const to avoid ambiguity in C++20. (#68805)

C++20 will automatically generate an operator== with reversed operand
order, which is ambiguous with the written operator== when one argument
is marked const and the other isn't.

This operator currently triggers -Wambiguous-reversed-operator at usage
site libc/test/UnitTest/PrintfMatcher.cpp:28.
This commit is contained in:
Samira Bazuzi 2023-10-11 23:59:13 -04:00 committed by GitHub
parent 1379a7286e
commit b5c2fa14ea
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -53,7 +53,7 @@ struct FormatSection {
// This operator is only used for testing and should be automatically
// optimized out for release builds.
bool operator==(const FormatSection &other) {
bool operator==(const FormatSection &other) const {
if (has_conv != other.has_conv)
return false;