Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2024-11-27 15:41:46 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[lldb] Replace another inconsequential radar link (NFC)

Browse Source 
The existing comment already explains what the problem is. The radar
tracks caching negative lookups in xcrun. Having a backlink is handy,
but it's not necessary as the radar references the LLDB workaround.
Furthermore, we have other places in LLDB that work around xcrun not
caching negative that should potentially be reconsidered at that time.
This commit is contained in:
Jonas Devlieghere 2023-07-30 15:19:09 -07:00
parent 144236a455
commit b699bf671a
No known key found for this signature in database
GPG Key ID: 49CC0BD90FDEED4D
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp
View File

@ -545,7 +545,7 @@ static bool shouldSkipSimulatorPlatform(bool force, const ArchSpec *arch) {
// If the arch is known not to specify a simulator environment, skip creating
// the simulator platform (we can create it later if there's a matching arch).
// This avoids very slow xcrun queries for non-simulator archs (the slowness
// is due to xcrun not caching negative queries (rdar://74882205)).
// is due to xcrun not caching negative queries.
return !force && arch && arch->IsValid() &&
!arch->TripleEnvironmentWasSpecified();
}