Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2024-11-23 05:40:09 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[lldb] Correct function names in ProcessGDBRemote::ParseFlagsFields log messages

Browse Source 
This has to be specified in the string because otherwise we'd get the
lambda's name, and I incorrectly used the name of the calling function here.
This commit is contained in:
David Spickett 2024-01-18 16:45:10 +00:00
parent 2b804f8755
commit b75b9d82f5
1 changed files with 33 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

62
lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
View File

@ -4189,52 +4189,55 @@ static std::vector<RegisterFlags::Field> ParseFlagsFields(XMLNode flags_node,
// Note that XML in general requires that each of these attributes only
// appears once, so we don't have to handle that here.
if (attr_name == "name") {
LLDB_LOG(log,
"ProcessGDBRemote::ParseFlags Found field node name \"{0}\"",
attr_value.data());
LLDB_LOG(
log,
"ProcessGDBRemote::ParseFlagsFields Found field node name \"{0}\"",
attr_value.data());
name = attr_value;
} else if (attr_name == "start") {
unsigned parsed_start = 0;
if (llvm::to_integer(attr_value, parsed_start)) {
if (parsed_start > max_start_bit) {
LLDB_LOG(
log,
"ProcessGDBRemote::ParseFlags Invalid start {0} in field node, "
"cannot be > {1}",
parsed_start, max_start_bit);
LLDB_LOG(log,
"ProcessGDBRemote::ParseFlagsFields Invalid start {0} in "
"field node, "
"cannot be > {1}",
parsed_start, max_start_bit);
} else
start = parsed_start;
} else {
LLDB_LOG(log,
"ProcessGDBRemote::ParseFlags Invalid start \"{0}\" in "
"field node",
attr_value.data());
LLDB_LOG(
log,
"ProcessGDBRemote::ParseFlagsFields Invalid start \"{0}\" in "
"field node",
attr_value.data());
}
} else if (attr_name == "end") {
unsigned parsed_end = 0;
if (llvm::to_integer(attr_value, parsed_end))
if (parsed_end > max_start_bit) {
LLDB_LOG(
log,
"ProcessGDBRemote::ParseFlags Invalid end {0} in field node, "
"cannot be > {1}",
parsed_end, max_start_bit);
LLDB_LOG(log,
"ProcessGDBRemote::ParseFlagsFields Invalid end {0} in "
"field node, "
"cannot be > {1}",
parsed_end, max_start_bit);
} else
end = parsed_end;
else {
LLDB_LOG(
log,
"ProcessGDBRemote::ParseFlags Invalid end \"{0}\" in field node",
attr_value.data());
LLDB_LOG(log,
"ProcessGDBRemote::ParseFlagsFields Invalid end \"{0}\" in "
"field node",
attr_value.data());
}
} else if (attr_name == "type") {
// Type is a known attribute but we do not currently use it and it is
// not required.
} else {
LLDB_LOG(log,
"ProcessGDBRemote::ParseFlags Ignoring unknown attribute "
"\"{0}\" in field node",
attr_name.data());
LLDB_LOG(
log,
"ProcessGDBRemote::ParseFlagsFields Ignoring unknown attribute "
"\"{0}\" in field node",
attr_name.data());
}
return true; // Walk all attributes of the field.
@ -4242,10 +4245,11 @@ static std::vector<RegisterFlags::Field> ParseFlagsFields(XMLNode flags_node,
if (name && start && end) {
if (*start > *end) {
LLDB_LOG(log,
"ProcessGDBRemote::ParseFlags Start {0} > end {1} in field "
"\"{2}\", ignoring",
*start, *end, name->data());
LLDB_LOG(
log,
"ProcessGDBRemote::ParseFlagsFields Start {0} > end {1} in field "
"\"{2}\", ignoring",
*start, *end, name->data());
} else {
fields.push_back(RegisterFlags::Field(name->str(), *start, *end));
}