Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2025-03-05 00:48:08 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

[RISCV] Only emit .option when extension is supported

Browse Source 
It maybe emit the .option directive without any follow up. Only emit the .option push/pop when there are supported extension difference between function and module.

Reviewed By: craig.topper

Differential Revision: https://reviews.llvm.org/D159399
This commit is contained in:
Piyou Chen 2023-09-18 00:18:49 -07:00
parent d861b3183c
commit b83a1ed594
2 changed files with 12 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp
View File

@ -88,8 +88,7 @@ public:
void emitEndOfAsmFile(Module &M) override;
void emitFunctionEntryLabel() override;
void emitDirectiveOptionArch();
bool isSameAttribute();
bool emitDirectiveOptionArch();
private:
void emitAttributes();
@ -252,7 +251,7 @@ bool RISCVAsmPrinter::PrintAsmMemoryOperand(const MachineInstr *MI,
return false;
}
void RISCVAsmPrinter::emitDirectiveOptionArch() {
bool RISCVAsmPrinter::emitDirectiveOptionArch() {
RISCVTargetStreamer &RTS =
static_cast<RISCVTargetStreamer &>(*OutStreamer->getTargetStreamer());
SmallVector<RISCVOptionArchArg> NeedEmitStdOptionArgs;
@ -268,28 +267,26 @@ void RISCVAsmPrinter::emitDirectiveOptionArch() {
: RISCVOptionArchArgType::Minus;
NeedEmitStdOptionArgs.emplace_back(Delta, Feature.Key);
}
if (!NeedEmitStdOptionArgs.empty())
if (!NeedEmitStdOptionArgs.empty()) {
RTS.emitDirectiveOptionPush();
RTS.emitDirectiveOptionArch(NeedEmitStdOptionArgs);
}
return true;
}
bool RISCVAsmPrinter::isSameAttribute() {
const MCSubtargetInfo &MCSTI = *TM.getMCSubtargetInfo();
return MCSTI.getFeatureBits() == STI->getFeatureBits();
return false;
}
bool RISCVAsmPrinter::runOnMachineFunction(MachineFunction &MF) {
STI = &MF.getSubtarget<RISCVSubtarget>();
RISCVTargetStreamer &RTS =
static_cast<RISCVTargetStreamer &>(*OutStreamer->getTargetStreamer());
if (!isSameAttribute()) {
RTS.emitDirectiveOptionPush();
emitDirectiveOptionArch();
}
bool EmittedOptionArch = emitDirectiveOptionArch();
SetupMachineFunction(MF);
emitFunctionBody();
if (!isSameAttribute())
if (EmittedOptionArch)
RTS.emitDirectiveOptionPop();
return false;
}

4
llvm/test/CodeGen/RISCV/riscv-func-target-feature.ll
View File

@ -35,10 +35,10 @@ entry:
ret void
}
; CHECK: .option push
; CHECK-NOT: .option push
define void @test5() "target-features"="+unaligned-scalar-mem" {
; CHECK-LABEL: test5
; CHECK: .option pop
; CHECK-NOT: .option pop
entry:
ret void
}