From b999ac1af60bce30341045a94b1d8a1638843c0a Mon Sep 17 00:00:00 2001 From: Kadir Cetinkaya Date: Mon, 24 Oct 2022 17:14:52 +0200 Subject: [PATCH] [llvm] Fix minimum Apple Clang requirement This was stated as 9.3, but as pointed out in https://discourse.llvm.org/t/rfc-bump-minimal-requirements-apple-clang-9-3-10-0-0-before-4th-tue-in-january/66156/7?u=kadircet 9.3 doesn't exist, hence this was effectively 10.0. This patch merely reflects the reality more closely. Differential Revision: https://reviews.llvm.org/D136609 --- llvm/cmake/modules/CheckCompilerVersion.cmake | 4 ++-- llvm/docs/GettingStarted.rst | 2 +- llvm/docs/ReleaseNotes.rst | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/llvm/cmake/modules/CheckCompilerVersion.cmake b/llvm/cmake/modules/CheckCompilerVersion.cmake index efe403f7f168..374ee8ffa400 100644 --- a/llvm/cmake/modules/CheckCompilerVersion.cmake +++ b/llvm/cmake/modules/CheckCompilerVersion.cmake @@ -8,8 +8,8 @@ set(GCC_MIN 7.1) set(GCC_SOFT_ERROR 7.1) set(CLANG_MIN 5.0) set(CLANG_SOFT_ERROR 5.0) -set(APPLECLANG_MIN 9.3) -set(APPLECLANG_SOFT_ERROR 9.3) +set(APPLECLANG_MIN 10.0) +set(APPLECLANG_SOFT_ERROR 10.0) # https://en.wikipedia.org/wiki/Microsoft_Visual_C#Internal_version_numbering # _MSC_VER == 1927 MSVC++ 14.27 Visual Studio 2019 Version 16.7 diff --git a/llvm/docs/GettingStarted.rst b/llvm/docs/GettingStarted.rst index f7c0cb78fc50..e14ee9d8c8c5 100644 --- a/llvm/docs/GettingStarted.rst +++ b/llvm/docs/GettingStarted.rst @@ -239,7 +239,7 @@ standards`. To enforce this language version, we check the most popular host toolchains for specific minimum versions in our build systems: * Clang 5.0 -* Apple Clang 9.3 +* Apple Clang 10.0 * GCC 7.1 * Visual Studio 2019 16.7 diff --git a/llvm/docs/ReleaseNotes.rst b/llvm/docs/ReleaseNotes.rst index 556f7fc7f544..1515fe47be37 100644 --- a/llvm/docs/ReleaseNotes.rst +++ b/llvm/docs/ReleaseNotes.rst @@ -61,7 +61,7 @@ and there is no way to suppress this error. * GCC >= 7.1 * Clang >= 5.0 -* Apple Clang >= 9.3 +* Apple Clang >= 10.0 * Visual Studio 2019 >= 16.7 Changes to the LLVM IR