Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2025-01-13 19:32:41 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

[docs] Minor updates to DeveloperPolicy due to svn to git

Browse Source 
Reviewed By: efriedma

Differential Revision: https://reviews.llvm.org/D73971
This commit is contained in:
Jinsong Ji 2020-02-12 21:07:40 +00:00
parent 905ccf8b2f
commit baf3a53b57
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
llvm/docs/DeveloperPolicy.rst
View File

@ -160,7 +160,7 @@ larger features. Accepted ways to speed up review times for your patches are:
Developers should participate in code reviews as both reviewers and
reviewees. If someone is kind enough to review your code, you should return the
favor for someone else. Note that anyone is welcome to review and give feedback
on a patch, but only people with Subversion write access can approve it.
on a patch, but only people with GitHub commit access can approve it.
There is a web based code review tool that can optionally be used
for code reviews. See :doc:`Phabricator`.
@ -325,9 +325,9 @@ Below are some guidelines about the format of the message itself:
and in-code comments, ex. capitalization, full stop, etc.
* If the commit is a bug fix on top of another recently committed patch, or a
revert or reapply of a patch, include the svn revision number of the prior
related commit. This could be as simple as "Revert rNNNN because it caused
PR#".
revert or reapply of a patch, include the git commit hash of the prior
related commit. This could be as simple as "Revert commit NNNN because it
caused PR#".
For minor violations of these recommendations, the community normally favors
reminding the contributor of this policy over reverting. Minor corrections and