Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2024-11-24 06:10:12 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[libc] Fix warnings on release build.

Browse Source 
Summary:
These warnings were present when building llvm-libc in release mode.

```
workspace/llvm-project/libc/utils/benchmarks/LibcMemoryBenchmarkTest.cpp:50:34: warning: 'None' is deprecated: Use Align() or Align(1) instead [-Wdeprecated-declarations]
  Conf.AddressAlignment = Align::None();

workspace/llvm-project/libc/utils/testutils/FDReaderUnix.cpp:19:7: warning: unused variable 'err' [-Wunused-variable]
  int err = ::pipe(pipefd);
```

For test-utils it seems in general we should use `report_fatal_error` instead of asserts as these are turned off when building in release mode.
https://llvm.org/docs/CodingStandards.html#assert-liberally

Reviewers: abrachet, sivachandra

Reviewed By: abrachet, sivachandra

Subscribers: tschuett, libc-commits

Tags: #libc-project

Differential Revision: https://reviews.llvm.org/D79469
This commit is contained in:
Paula Toth 2020-05-07 11:55:29 -07:00
parent e6fbce675d
commit bf6f3894c4
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
libc/utils/benchmarks/LibcMemoryBenchmarkTest.cpp
View File

@ -47,7 +47,6 @@ TEST(OffsetDistribution, AlignToBegin) {
TEST(OffsetDistribution, NoAlignment) {
StudyConfiguration Conf;
Conf.BufferSize = 8192;
Conf.AddressAlignment = Align::None();
Conf.Size.To = 1;
OffsetDistribution OD(Conf);

4
libc/utils/testutils/FDReaderUnix.cpp
View File

@ -16,8 +16,8 @@ namespace __llvm_libc {
namespace testutils {
FDReader::FDReader() {
int err = ::pipe(pipefd);
assert(!err && "pipe(2) failed");
if (::pipe(pipefd))
llvm::report_fatal_error("pipe(2) failed");
}
FDReader::~FDReader() {