Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2024-11-27 23:51:56 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[clang][index] Fix a crash for accessing a null field decl.

Browse Source 
getField() may return a nullptr, we already did that in
BodyIndexer::VisitDesignatedInitExpr, but missed one place.
This commit is contained in:
Haojian Wu 2020-05-20 23:15:08 +02:00
parent 1c3d9c2f36
commit c2c36c4f4b
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clang/lib/Index/IndexBody.cpp
View File

@ -414,7 +414,7 @@ public:
auto visitSyntacticDesignatedInitExpr = [&](DesignatedInitExpr *E) -> bool {
for (DesignatedInitExpr::Designator &D : llvm::reverse(E->designators())) {
if (D.isFieldDesignator())
if (D.isFieldDesignator() && D.getField())
return IndexCtx.handleReference(D.getField(), D.getFieldLoc(),
Parent, ParentDC, SymbolRoleSet(),
{}, E);

8
clang/test/Index/index-designated-init-recovery.cpp Normal file
View File

@ -0,0 +1,8 @@
struct Bar {};
struct Foo {
void method(Bar bar) {}
};
void NoCrash(Foo t) {
t.method({.abc = 50}); // CHECK: field designator 'abc' does not refer to any field in type 'Bar'
}
// RUN: c-index-test -index-file %s -Xclang -frecovery-ast 2>&1 | FileCheck %s