From c3741ec8d364bb2490cf4abc0d3128cbad51f169 Mon Sep 17 00:00:00 2001 From: Benjamin Kramer Date: Mon, 12 Oct 2015 09:22:07 +0000 Subject: [PATCH] [VFS] remove handling of '..' for now. This can fail badly if we're overlaying a real file system and there are symlinks there. Just keep the path as-is for now. This essentially reverts r249830. llvm-svn: 250021 --- clang/lib/Basic/VirtualFileSystem.cpp | 4 ++-- clang/unittests/Basic/VirtualFileSystemTest.cpp | 3 --- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/clang/lib/Basic/VirtualFileSystem.cpp b/clang/lib/Basic/VirtualFileSystem.cpp index ced370c6f357..cb09e2ec84f3 100644 --- a/clang/lib/Basic/VirtualFileSystem.cpp +++ b/clang/lib/Basic/VirtualFileSystem.cpp @@ -497,7 +497,7 @@ void InMemoryFileSystem::addFile(const Twine &P, time_t ModificationTime, assert(!EC); (void)EC; - FileManager::removeDotPaths(Path, /*RemoveDotDot=*/true); + FileManager::removeDotPaths(Path, /*RemoveDotDot=*/false); if (Path.empty()) return; @@ -556,7 +556,7 @@ lookupInMemoryNode(const InMemoryFileSystem &FS, detail::InMemoryDirectory *Dir, assert(!EC); (void)EC; - FileManager::removeDotPaths(Path, /*RemoveDotDot=*/true); + FileManager::removeDotPaths(Path, /*RemoveDotDot=*/false); if (Path.empty()) return Dir; diff --git a/clang/unittests/Basic/VirtualFileSystemTest.cpp b/clang/unittests/Basic/VirtualFileSystemTest.cpp index b98e999cd601..6ed811f22f3f 100644 --- a/clang/unittests/Basic/VirtualFileSystemTest.cpp +++ b/clang/unittests/Basic/VirtualFileSystemTest.cpp @@ -569,7 +569,6 @@ TEST_F(InMemoryFileSystemTest, OverlayFileNoOwn) { TEST_F(InMemoryFileSystemTest, OpenFileForRead) { FS.addFile("/a", 0, MemoryBuffer::getMemBuffer("a")); FS.addFile("././c", 0, MemoryBuffer::getMemBuffer("c")); - FS.addFile("./d/../d", 0, MemoryBuffer::getMemBuffer("d")); auto File = FS.openFileForRead("/a"); ASSERT_EQ("a", (*(*File)->getBuffer("ignored"))->getBuffer()); File = FS.openFileForRead("/a"); // Open again. @@ -582,8 +581,6 @@ TEST_F(InMemoryFileSystemTest, OpenFileForRead) { ASSERT_EQ(File.getError(), errc::no_such_file_or_directory) << FS.toString(); File = FS.openFileForRead("./c"); ASSERT_EQ("c", (*(*File)->getBuffer("ignored"))->getBuffer()); - File = FS.openFileForRead("e/../d"); - ASSERT_EQ("d", (*(*File)->getBuffer("ignored"))->getBuffer()); } TEST_F(InMemoryFileSystemTest, DirectoryIteration) {