From c3aed0d395950c23d66c3ec0af4b1a2ec2534795 Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Sat, 25 Sep 2021 17:24:55 +0000 Subject: [PATCH] MLIR can't support -Bsymbolic link option, fail at CMake time with a helpful message instead of broken runtime Differential Revision: https://reviews.llvm.org/D110483 --- mlir/CMakeLists.txt | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/mlir/CMakeLists.txt b/mlir/CMakeLists.txt index 54ea572ae5f3..b7ac3bdc543f 100644 --- a/mlir/CMakeLists.txt +++ b/mlir/CMakeLists.txt @@ -37,6 +37,12 @@ list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules") include(AddMLIR) +# -BSymbolic is incompatible with TypeID +if("${CMAKE_SHARED_LINKER_FLAGS}" MATCHES "-Bsymbolic[^-]") + message(FATAL_ERROR " MLIR does not support `-Bsymbolic` (see http://llvm.org/pr51420 )," + " try `-Bsymbolic-functions` instead.") +endif() + # Forbid implicit function declaration: this may lead to subtle bugs and we # don't have a reason to support this. check_c_compiler_flag("-Werror=implicit-function-declaration" C_SUPPORTS_WERROR_IMPLICIT_FUNCTION_DECLARATION)