Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2024-12-25 17:31:02 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[llvm-objdump] Keep warning for --disassemble-functions in correct order.

Browse Source 
relative to normal output when dumping archive files.

prepare for PR35351.

Reviewers: jhenderson, grimar, MaskRay, rupprecht

Reviewed by: MaskRay, jhenderson

Differential Revision: https://reviews.llvm.org/D64165

llvm-svn: 365564
This commit is contained in:
Yuanfang Chen 2019-07-09 21:53:33 +00:00
parent 50d7f46460
commit c5f8aa8bea
2 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
llvm/test/tools/llvm-objdump/X86/warn-missing-disasm-func.test
View File

@ -1,5 +1,10 @@
## Warn if --disassemble-functions specifies an unknown symbol.
# RUN: yaml2obj %s | llvm-objdump - --disassemble-functions=foo 2>&1 | FileCheck %s
# RUN: yaml2obj -o %t.o %s
# RUN: rm -f %t.a
# RUN: llvm-ar qc %t.a %t.o %t.o
# RUN: llvm-objdump --disassemble-functions=foo %t.o 2>&1 | FileCheck %s
# RUN: llvm-objdump --disassemble-functions=foo %t.a 2>&1 | FileCheck %s --check-prefix=MULTI
--- !ELF
FileHeader:
@ -9,3 +14,8 @@ FileHeader:
Machine: EM_X86_64
# CHECK: warning: failed to disassemble missing function foo
# MULTI: file format ELF64-x86-64
# MULTI: warning: failed to disassemble missing function foo
# MULTI: file format ELF64-x86-64
# MULTI: warning: failed to disassemble missing function foo

6
llvm/tools/llvm-objdump/llvm-objdump.cpp
View File

@ -386,8 +386,12 @@ void warn(StringRef Message) {
errs().flush();
}
void warn(Twine Message) {
static void warn(Twine Message) {
// Output order between errs() and outs() matters especially for archive
// files where the output is per member object.
outs().flush();
WithColor::warning(errs(), ToolName) << Message << "\n";
errs().flush();
}
LLVM_ATTRIBUTE_NORETURN void report_error(StringRef File, Twine Message) {