diff --git a/clang/include/clang/StaticAnalyzer/Frontend/CheckerRegistry.h b/clang/include/clang/StaticAnalyzer/Frontend/CheckerRegistry.h index ab8fff0ce7d2..052ef66e60e3 100644 --- a/clang/include/clang/StaticAnalyzer/Frontend/CheckerRegistry.h +++ b/clang/include/clang/StaticAnalyzer/Frontend/CheckerRegistry.h @@ -195,6 +195,12 @@ private: CheckerInfoList Checkers; llvm::StringMap PackageSizes; + /// Contains all (Dependendent checker, Dependency) pairs. We need this, as + /// we'll resolve dependencies after all checkers were added first. + llvm::SmallVector, 0> Dependencies; + + void resolveDependencies(); + DiagnosticsEngine &Diags; AnalyzerOptions &AnOpts; const LangOptions &LangOpts; diff --git a/clang/lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp b/clang/lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp index 3ee35b4aeea9..8f1c87a92ee5 100644 --- a/clang/lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp +++ b/clang/lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp @@ -177,6 +177,8 @@ CheckerRegistry::CheckerRegistry( #undef CHECKER_DEPENDENCY #undef GET_CHECKER_DEPENDENCIES + resolveDependencies(); + // Parse '-analyzer-checker' and '-analyzer-disable-checker' options from the // command line. for (const std::pair &Opt : AnOpts.CheckersControlList) { @@ -278,18 +280,26 @@ void CheckerRegistry::addChecker(InitializationFunction Rfn, } } +void CheckerRegistry::resolveDependencies() { + for (const std::pair &Entry : Dependencies) { + auto CheckerIt = binaryFind(Checkers, Entry.first); + assert(CheckerIt != Checkers.end() && CheckerIt->FullName == Entry.first && + "Failed to find the checker while attempting to set up its " + "dependencies!"); + + auto DependencyIt = binaryFind(Checkers, Entry.second); + assert(DependencyIt != Checkers.end() && + DependencyIt->FullName == Entry.second && + "Failed to find the dependency of a checker!"); + + CheckerIt->Dependencies.emplace_back(&*DependencyIt); + } + + Dependencies.clear(); +} + void CheckerRegistry::addDependency(StringRef FullName, StringRef Dependency) { - auto CheckerIt = binaryFind(Checkers, FullName); - assert(CheckerIt != Checkers.end() && CheckerIt->FullName == FullName && - "Failed to find the checker while attempting to set up its " - "dependencies!"); - - auto DependencyIt = binaryFind(Checkers, Dependency); - assert(DependencyIt != Checkers.end() && - DependencyIt->FullName == Dependency && - "Failed to find the dependency of a checker!"); - - CheckerIt->Dependencies.emplace_back(&*DependencyIt); + Dependencies.emplace_back(FullName, Dependency); } void CheckerRegistry::initializeManager(CheckerManager &CheckerMgr) const { diff --git a/clang/test/Analysis/checker-dependencies.c b/clang/test/Analysis/checker-dependencies.c index efb636db22ac..6c8583adb35d 100644 --- a/clang/test/Analysis/checker-dependencies.c +++ b/clang/test/Analysis/checker-dependencies.c @@ -1,3 +1,20 @@ // RUN: %clang_analyze_cc1 %s \ // RUN: -analyzer-checker=core \ // RUN: -analyzer-checker=nullability.NullReturnedFromNonnull + +// RUN: %clang_analyze_cc1 %s \ +// RUN: -analyzer-checker=osx.cocoa.RetainCount \ +// RUN: -analyzer-list-enabled-checkers \ +// RUN: 2>&1 | FileCheck %s -check-prefix=CHECK-IMPLICITLY-ENABLED + +// CHECK-IMPLICITLY-ENABLED: osx.cocoa.RetainCountBase +// CHECK-IMPLICITLY-ENABLED: osx.cocoa.RetainCount + +// RUN: %clang_analyze_cc1 %s \ +// RUN: -analyzer-checker=osx.cocoa.RetainCount \ +// RUN: -analyzer-disable-checker=osx.cocoa.RetainCountBase \ +// RUN: -analyzer-list-enabled-checkers \ +// RUN: 2>&1 | FileCheck %s -check-prefix=CHECK-IMPLICITLY-DISABLED + +// CHECK-IMPLICITLY-DISABLED-NOT: osx.cocoa.RetainCountBase +// CHECK-IMPLICITLY-DISABLED-NOT: osx.cocoa.RetainCount