Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2024-11-23 13:50:11 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[lldb] Add actionable feedback when overwriting a command fails (#76030)

Browse Source 
If adding a user commands fails because a command with the same name
already exists, we only say that "force replace is not set" without
telling the user _how_ to set it. There are two ways to do so; this
commit changes the error message to mention both.
This commit is contained in:
Felipe de Azevedo Piovezan 2023-12-21 09:04:24 -03:00 committed by GitHub
parent e6d2bb0ed8
commit cf0be7b492
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lldb/source/Interpreter/CommandInterpreter.cpp
View File

@ -1160,7 +1160,11 @@ Status CommandInterpreter::AddUserCommand(llvm::StringRef name,
if (UserCommandExists(name)) {
if (!can_replace) {
result.SetErrorString("user command exists and force replace not set");
result.SetErrorStringWithFormatv(
"user command \"{0}\" already exists and force replace was not set "
"by --overwrite or 'settings set interpreter.require-overwrite "
"false'",
name);
return result;
}
if (cmd_sp->IsMultiwordObject()) {

13
lldb/test/API/commands/command/script/TestCommandScript.py
View File

@ -161,6 +161,19 @@ class CmdPythonTestCase(TestBase):
)
self.expect("my_command", substrs=["a.out"])
# Test that without --overwrite we are not allowed to redefine the command.
self.expect(
"command script add my_command --class welcome.TargetnameCommand",
substrs=[
(
'user command "my_command" already exists and force replace was'
" not set by --overwrite or 'settings set"
" interpreter.require-overwrite false'"
),
],
error=True,
)
self.runCmd("command script clear")
self.expect(