Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2025-03-04 08:27:50 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[flang] Fix SPACING() of very small values

Browse Source 
SPACING() must return TINY() for zero arguments (which we do)
and also for subnormal values smaller than TINY() in absolute value,
which we get wrong.  Fix folding and the runtime.

Differential Revision: https://reviews.llvm.org/D151272
This commit is contained in:
Peter Klausler 2023-05-23 13:55:23 -07:00
parent 1234fc3021
commit d71297ce74
No known key found for this signature in database
3 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
flang/lib/Evaluate/real.cpp
View File

@ -745,12 +745,12 @@ template <typename W, int P> Real<W, P> Real<W, P>::SPACING() const {
return *this; return *this;
} else if (IsInfinite()) { } else if (IsInfinite()) {
return NotANumber(); return NotANumber();
} else if (IsZero()) { } else if (IsZero() || IsSubnormal()) {
return TINY(); return TINY(); // mandated by standard
} else { } else {
Real result; Real result;
result.Normalize(false, Exponent(), Fraction::MASKR(1)); result.Normalize(false, Exponent(), Fraction::MASKR(1));
return result; return result.IsZero() ? TINY() : result;
} }
} }

5
flang/runtime/numeric.cpp
View File

@ -239,8 +239,9 @@ template <int PREC, typename T> inline T Spacing(T x) {
// subnormal. // subnormal.
return std::numeric_limits<T>::min(); // 0 -> TINY(x) return std::numeric_limits<T>::min(); // 0 -> TINY(x)
} else { } else {
return std::ldexp( T result{
static_cast<T>(1.0), std::ilogb(x) + 1 - PREC); // 2**(e-p) std::ldexp(static_cast<T>(1.0), std::ilogb(x) + 1 - PREC)}; // 2**(e-p)
return result == 0 ? /*TINY(x)*/ std::numeric_limits<T>::min() : result;
} }
} }

1
flang/test/Evaluate/fold-spacing.f90
View File

@ -7,6 +7,7 @@ module m
logical, parameter :: test_4 = spacing(0.) == tiny(0.) logical, parameter :: test_4 = spacing(0.) == tiny(0.)
logical, parameter :: test_5 = spacing(tiny(0.)) == 1.e-45 logical, parameter :: test_5 = spacing(tiny(0.)) == 1.e-45
logical, parameter :: test_6 = spacing(8388608.) == 1. logical, parameter :: test_6 = spacing(8388608.) == 1.
logical, parameter :: test_7 = spacing(spacing(tiny(.0))) == tiny(0.)
logical, parameter :: test_11 = rrspacing(3.0) == scale(0.75, 24) logical, parameter :: test_11 = rrspacing(3.0) == scale(0.75, 24)
logical, parameter :: test_12 = rrspacing(-3.0) == scale(0.75, 24) logical, parameter :: test_12 = rrspacing(-3.0) == scale(0.75, 24)
logical, parameter :: test_13 = rrspacing(3.0d0) == scale(0.75, 53) logical, parameter :: test_13 = rrspacing(3.0d0) == scale(0.75, 53)