Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2025-04-03 22:02:12 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[IRMover] Use GlobalValue::getAddressSpace instead of directly from its type [NFC]

Browse Source 
Summary: Change the old form of G->getType()->getAddressSpace() to the new G->getAddressSpace() (underneath does the same).

Patch by Ehud Katz <ehudkatz@gmail.com>

Reviewers: tejohnson, chandlerc

Reviewed By: tejohnson

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D69550
This commit is contained in:
Teresa Johnson 2019-11-05 13:07:20 -08:00
parent 37f4955c9b
commit dce53d7198
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
llvm/lib/Linker/IRMover.cpp
View File

@ -628,7 +628,7 @@ GlobalVariable *IRLinker::copyGlobalVariableProto(const GlobalVariable *SGVar) {
SGVar->isConstant(), GlobalValue::ExternalLinkage, SGVar->isConstant(), GlobalValue::ExternalLinkage,
/*init*/ nullptr, SGVar->getName(), /*init*/ nullptr, SGVar->getName(),
/*insertbefore*/ nullptr, SGVar->getThreadLocalMode(), /*insertbefore*/ nullptr, SGVar->getThreadLocalMode(),
SGVar->getType()->getAddressSpace()); SGVar->getAddressSpace());
NewDGV->setAlignment(MaybeAlign(SGVar->getAlignment())); NewDGV->setAlignment(MaybeAlign(SGVar->getAlignment()));
NewDGV->copyAttributesFrom(SGVar); NewDGV->copyAttributesFrom(SGVar);
return NewDGV; return NewDGV;
@ -671,11 +671,11 @@ IRLinker::copyGlobalIndirectSymbolProto(const GlobalIndirectSymbol *SGIS) {
auto *Ty = TypeMap.get(SGIS->getValueType()); auto *Ty = TypeMap.get(SGIS->getValueType());
GlobalIndirectSymbol *GIS; GlobalIndirectSymbol *GIS;
if (isa<GlobalAlias>(SGIS)) if (isa<GlobalAlias>(SGIS))
GIS = GlobalAlias::create(Ty, SGIS->getType()->getPointerAddressSpace(), GIS = GlobalAlias::create(Ty, SGIS->getAddressSpace(),
GlobalValue::ExternalLinkage, SGIS->getName(), GlobalValue::ExternalLinkage, SGIS->getName(),
&DstM); &DstM);
else else
GIS = GlobalIFunc::create(Ty, SGIS->getType()->getPointerAddressSpace(), GIS = GlobalIFunc::create(Ty, SGIS->getAddressSpace(),
GlobalValue::ExternalLinkage, SGIS->getName(), GlobalValue::ExternalLinkage, SGIS->getName(),
nullptr, &DstM); nullptr, &DstM);
GIS->copyAttributesFrom(SGIS); GIS->copyAttributesFrom(SGIS);
@ -697,12 +697,12 @@ GlobalValue *IRLinker::copyGlobalValueProto(const GlobalValue *SGV,
Function::Create(cast<FunctionType>(TypeMap.get(SGV->getValueType())), Function::Create(cast<FunctionType>(TypeMap.get(SGV->getValueType())),
GlobalValue::ExternalLinkage, SGV->getName(), &DstM); GlobalValue::ExternalLinkage, SGV->getName(), &DstM);
else else
NewGV = new GlobalVariable( NewGV =
DstM, TypeMap.get(SGV->getValueType()), new GlobalVariable(DstM, TypeMap.get(SGV->getValueType()),
/*isConstant*/ false, GlobalValue::ExternalLinkage, /*isConstant*/ false, GlobalValue::ExternalLinkage,
/*init*/ nullptr, SGV->getName(), /*init*/ nullptr, SGV->getName(),
/*insertbefore*/ nullptr, SGV->getThreadLocalMode(), /*insertbefore*/ nullptr,
SGV->getType()->getAddressSpace()); SGV->getThreadLocalMode(), SGV->getAddressSpace());
} }
if (ForDefinition) if (ForDefinition)
@ -918,7 +918,7 @@ IRLinker::linkAppendingVarProto(GlobalVariable *DstGV,
GlobalVariable *NG = new GlobalVariable( GlobalVariable *NG = new GlobalVariable(
DstM, NewType, SrcGV->isConstant(), SrcGV->getLinkage(), DstM, NewType, SrcGV->isConstant(), SrcGV->getLinkage(),
/*init*/ nullptr, /*name*/ "", DstGV, SrcGV->getThreadLocalMode(), /*init*/ nullptr, /*name*/ "", DstGV, SrcGV->getThreadLocalMode(),
SrcGV->getType()->getAddressSpace()); SrcGV->getAddressSpace());
NG->copyAttributesFrom(SrcGV); NG->copyAttributesFrom(SrcGV);
forceRenaming(NG, SrcGV->getName()); forceRenaming(NG, SrcGV->getName());