Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2025-02-05 17:12:00 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[OpenMP][NFC] Fix not sustitution in tests

Browse Source 
D78566 introduced a `\bnot\b` lit substitution in OpenMP test suites.
However, that would corrupt a command like
`FileCheck -implicit-check-not` or any file name like `%t.not`.  We
could use lookbehind/lookahead assertions to avoid such cases, but
this patch switches to `%not` (suggested during the D78566 review) as
a safer option.

Reviewed By: jdoerfert

Differential Revision: https://reviews.llvm.org/D79529
This commit is contained in:
Joel E. Denny 2020-05-11 09:51:32 -04:00
parent 99aa87a5b5
commit dd5ba4b585
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openmp/libomptarget/deviceRTLs/nvptx/test/lit.cfg
View File

@ -67,4 +67,4 @@ config.substitutions.append(("%openmp_flags", config.test_openmp_flags))
config.substitutions.append(("%flags", config.test_flags))
config.substitutions.append(("%run", "%t"))
config.substitutions.append((r"\bnot\b", config.libomptarget_not))
config.substitutions.append(("%not", config.libomptarget_not))

4
openmp/libomptarget/test/lit.cfg
View File

@ -103,7 +103,7 @@ for libomptarget_target in config.libomptarget_all_targets:
"%t-" + libomptarget_target))
config.substitutions.append(("%libomptarget-run-fail-" + \
libomptarget_target, \
"not %t-" + libomptarget_target))
"%not %t-" + libomptarget_target))
config.substitutions.append(("%clangxx-" + libomptarget_target, \
"%clangxx %openmp_flags %flags -fopenmp-targets=" + libomptarget_target))
config.substitutions.append(("%clang-" + libomptarget_target, \
@ -146,4 +146,4 @@ config.substitutions.append(("%clangxx", config.test_cxx_compiler))
config.substitutions.append(("%clang", config.test_c_compiler))
config.substitutions.append(("%openmp_flags", config.test_openmp_flags))
config.substitutions.append(("%flags", config.test_flags))
config.substitutions.append((r"\bnot\b", config.libomptarget_not))
config.substitutions.append(("%not", config.libomptarget_not))

2
openmp/runtime/test/lit.cfg
View File

@ -127,7 +127,7 @@ config.substitutions.append(("%clang", config.test_c_compiler))
config.substitutions.append(("%openmp_flags", config.test_openmp_flags))
config.substitutions.append(("%flags", config.test_flags))
config.substitutions.append(("%python", '"%s"' % (sys.executable)))
config.substitutions.append((r"\bnot\b", config.test_not))
config.substitutions.append(("%not", config.test_not))
if config.has_ompt:
config.substitutions.append(("FileCheck", "tee %%t.out | %s" % config.test_filecheck))

2
openmp/tools/archer/tests/lit.cfg
View File

@ -111,7 +111,7 @@ config.substitutions.append(("%suppression", "env TSAN_OPTIONS='ignore_noninstru
config.substitutions.append(("%deflake", os.path.join(os.path.dirname(__file__), "deflake.bash")))
config.substitutions.append(("FileCheck", config.test_filecheck))
config.substitutions.append((r"\bnot\b", config.test_not))
config.substitutions.append(("%not", config.test_not))
config.substitutions.append(("%sort-threads", "sort --numeric-sort --stable"))
if config.operating_system == 'Windows':
# No such environment variable on Windows.