Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2025-01-17 05:24:49 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Make parameter lists of SymbolTable::add* functions more consistent. NFC.

Browse Source 
llvm-svn: 314591
This commit is contained in:
Rui Ueyama 2017-09-30 12:41:34 +00:00
parent fbc622d1e4
commit de3d0cc894
3 changed files with 19 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lld/ELF/InputFiles.cpp
View File

@ -616,7 +616,8 @@ ArchiveFile::ArchiveFile(std::unique_ptr<Archive> &&File)
template <class ELFT> void ArchiveFile::parse() {
Symbols.reserve(File->getNumberOfSymbols());
for (const Archive::Symbol &Sym : File->symbols())
Symbols.push_back(Symtab->addLazyArchive<ELFT>(this, Sym)->body());
Symbols.push_back(
Symtab->addLazyArchive<ELFT>(Sym.getName(), this, Sym)->body());
}
// Returns a buffer pointing to a member file containing a given symbol.
@ -779,14 +780,14 @@ template <class ELFT> void SharedFile<ELFT>::parseRest() {
VersymIndex == VER_NDX_GLOBAL ? nullptr : Verdefs[VersymIndex];
if (!Hidden)
Symtab->addShared(this, Name, Sym, V);
Symtab->addShared(Name, this, Sym, V);
// Also add the symbol with the versioned name to handle undefined symbols
// with explicit versions.
if (V) {
StringRef VerName = this->StringTable.data() + V->getAux()->vda_name;
Name = Saver.save(Name + "@" + VerName);
Symtab->addShared(this, Name, Sym, V);
Symtab->addShared(Name, this, Sym, V);
}
}
}

21
lld/ELF/SymbolTable.cpp
View File

@ -472,7 +472,7 @@ Symbol *SymbolTable::addRegular(StringRef Name, uint8_t StOther, uint8_t Type,
}
template <typename ELFT>
void SymbolTable::addShared(SharedFile<ELFT> *File, StringRef Name,
void SymbolTable::addShared(StringRef Name, SharedFile<ELFT> *File,
const typename ELFT::Sym &Sym,
const typename ELFT::Verdef *Verdef) {
// DSO symbols do not affect visibility in the output, so we pass STV_DEFAULT
@ -533,11 +533,10 @@ void SymbolTable::defsym(Symbol *Dst, Symbol *Src) {
}
template <class ELFT>
Symbol *SymbolTable::addLazyArchive(ArchiveFile *F,
Symbol *SymbolTable::addLazyArchive(StringRef Name, ArchiveFile *F,
const object::Archive::Symbol Sym) {
Symbol *S;
bool WasInserted;
StringRef Name = Sym.getName();
std::tie(S, WasInserted) = insert(Name);
if (WasInserted) {
replaceBody<LazyArchive>(S, F, Sym, SymbolBody::UnknownType);
@ -840,16 +839,16 @@ template DefinedRegular *SymbolTable::addIgnored<ELF64LE>(StringRef, uint8_t);
template DefinedRegular *SymbolTable::addIgnored<ELF64BE>(StringRef, uint8_t);
template Symbol *
SymbolTable::addLazyArchive<ELF32LE>(ArchiveFile *,
SymbolTable::addLazyArchive<ELF32LE>(StringRef, ArchiveFile *,
const object::Archive::Symbol);
template Symbol *
SymbolTable::addLazyArchive<ELF32BE>(ArchiveFile *,
SymbolTable::addLazyArchive<ELF32BE>(StringRef, ArchiveFile *,
const object::Archive::Symbol);
template Symbol *
SymbolTable::addLazyArchive<ELF64LE>(ArchiveFile *,
SymbolTable::addLazyArchive<ELF64LE>(StringRef, ArchiveFile *,
const object::Archive::Symbol);
template Symbol *
SymbolTable::addLazyArchive<ELF64BE>(ArchiveFile *,
SymbolTable::addLazyArchive<ELF64BE>(StringRef, ArchiveFile *,
const object::Archive::Symbol);
template void SymbolTable::addLazyObject<ELF32LE>(StringRef, LazyObjFile &);
@ -857,16 +856,16 @@ template void SymbolTable::addLazyObject<ELF32BE>(StringRef, LazyObjFile &);
template void SymbolTable::addLazyObject<ELF64LE>(StringRef, LazyObjFile &);
template void SymbolTable::addLazyObject<ELF64BE>(StringRef, LazyObjFile &);
template void SymbolTable::addShared<ELF32LE>(SharedFile<ELF32LE> *, StringRef,
template void SymbolTable::addShared<ELF32LE>(StringRef, SharedFile<ELF32LE> *,
const typename ELF32LE::Sym &,
const typename ELF32LE::Verdef *);
template void SymbolTable::addShared<ELF32BE>(SharedFile<ELF32BE> *, StringRef,
template void SymbolTable::addShared<ELF32BE>(StringRef, SharedFile<ELF32BE> *,
const typename ELF32BE::Sym &,
const typename ELF32BE::Verdef *);
template void SymbolTable::addShared<ELF64LE>(SharedFile<ELF64LE> *, StringRef,
template void SymbolTable::addShared<ELF64LE>(StringRef, SharedFile<ELF64LE> *,
const typename ELF64LE::Sym &,
const typename ELF64LE::Verdef *);
template void SymbolTable::addShared<ELF64BE>(SharedFile<ELF64BE> *, StringRef,
template void SymbolTable::addShared<ELF64BE>(StringRef, SharedFile<ELF64BE> *,
const typename ELF64BE::Sym &,
const typename ELF64BE::Verdef *);

8
lld/ELF/SymbolTable.h
View File

@ -62,18 +62,20 @@ public:
SectionBase *Section, InputFile *File);
template <class ELFT>
void addShared(SharedFile<ELFT> *F, StringRef Name,
void addShared(StringRef Name, SharedFile<ELFT> *F,
const typename ELFT::Sym &Sym,
const typename ELFT::Verdef *Verdef);
template <class ELFT>
Symbol *addLazyArchive(ArchiveFile *F, const llvm::object::Archive::Symbol S);
Symbol *addLazyArchive(StringRef Name, ArchiveFile *F,
const llvm::object::Archive::Symbol S);
template <class ELFT> void addLazyObject(StringRef Name, LazyObjFile &Obj);
Symbol *addBitcode(StringRef Name, uint8_t Binding, uint8_t StOther,
uint8_t Type, bool CanOmitFromDynSym, BitcodeFile *File);
Symbol *addCommon(StringRef N, uint64_t Size, uint32_t Alignment,
Symbol *addCommon(StringRef Name, uint64_t Size, uint32_t Alignment,
uint8_t Binding, uint8_t StOther, uint8_t Type,
InputFile *File);