Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2025-02-12 21:28:48 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[BOLT] Fix deadloop bug in taildup

Browse Source 
The intent is clearly to push the tail rather than current BB.

Reviewed By: maksfb

Differential Revision: https://reviews.llvm.org/D159289
This commit is contained in:
zhoujing 2023-09-15 21:34:59 +08:00 committed by hezuoqiang
parent e8b1af9a55
commit de6a919f77
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
bolt/lib/Passes/TailDuplication.cpp
View File

@ -303,7 +303,7 @@ TailDuplication::aggressiveDuplicate(BinaryBasicBlock &BB,
if (isInCacheLine(BB, Tail))
return BlocksToDuplicate;
BinaryBasicBlock *CurrBB = &BB;
BinaryBasicBlock *CurrBB = &Tail;
while (CurrBB) {
LLVM_DEBUG(dbgs() << "Aggressive tail duplication: adding "
<< CurrBB->getName() << " to duplication list\n";);

9
bolt/test/X86/tail-duplication-pass.s
View File

@ -7,12 +7,21 @@
# RUN: llvm-bolt %t.exe --data %t.fdata --reorder-blocks=ext-tsp \
# RUN: --print-finalized --tail-duplication=moderate \
# RUN: --tail-duplication-minimum-offset=1 -o %t.out | FileCheck %s
# RUN: llvm-bolt %t.exe --data %t.fdata --print-finalized \
# RUN: --tail-duplication=aggressive --tail-duplication-minimum-offset=1 \
# RUN: -o %t.out | FileCheck %s --check-prefix CHECK-NOLOOP
# FDATA: 1 main 2 1 main #.BB2# 0 10
# FDATA: 1 main 4 1 main #.BB2# 0 20
# CHECK: BOLT-INFO: tail duplication modified 1 ({{.*}}%) functions; duplicated 1 blocks (1 bytes) responsible for {{.*}} dynamic executions ({{.*}}% of all block executions)
# CHECK: BB Layout : .LBB00, .Ltail-dup0, .Ltmp0, .Ltmp1
# Check that the successor of Ltail-dup0 is .LBB00, not itself.
# CHECK-NOLOOP: .Ltail-dup0 (1 instructions, align : 1)
# CHECK-NOLOOP: Predecessors: .LBB00
# CHECK-NOLOOP: retq
# CHECK-NOLOOP: .Ltmp0 (1 instructions, align : 1)
.text
.globl main
.type main, %function