Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2024-12-03 11:23:58 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[lldb/Reproducers] Override capture with LLDB_CAPTURE_REPRODUCER env var

Browse Source 
Make it possible to override reproducer capture with the
LLDB_CAPTURE_REPRODUCER environment variable.

The goal of this change is twofold.

(1) I want to be able to enable capturing reproducers during regular
    test runs, both locally and on the bots. To do so I need a way to
    force capture. I cannot do this through the Python API, because
    reproducer capture must be enabled *before* the debugger
    initialized, which happens automatically when doing `import lldb`.

(2) I want to provide an escape hatch for when reproducers are enabled
    by default. Downstream we have reproducer capture enabled by default
    in the driver.

This patch solves both problems by overriding the reproducer mode based
on the environment variable. Acceptable values are 0/1 and ON/OFF.
This commit is contained in:
Jonas Devlieghere 2019-12-04 16:06:48 -08:00
parent f65267ee16
commit dfe9a7943b
3 changed files with 31 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lldb/source/Utility/Reproducer.cpp
View File

@ -25,6 +25,16 @@ llvm::Error Reproducer::Initialize(ReproducerMode mode,
lldbassert(!InstanceImpl() && "Already initialized.");
InstanceImpl().emplace();
// The environment can override the capture mode.
if (mode != ReproducerMode::Replay) {
std::string env =
llvm::StringRef(getenv("LLDB_CAPTURE_REPRODUCER")).lower();
if (env == "0" || env == "off")
mode = ReproducerMode::Off;
else if (env == "1" || env == "on")
mode = ReproducerMode::Capture;
}
switch (mode) {
case ReproducerMode::Capture: {
if (!root) {

20
lldb/test/Shell/Reproducer/TestCaptureEnvOverride.test Normal file
View File

@ -0,0 +1,20 @@
# UNSUPPORTED: system-windows
# This tests the LLDB_CAPTURE_REPRODUCER override.
# RUN: %lldb -b -o 'reproducer status' --capture --capture-path %t.repro /bin/ls | FileCheck %s --check-prefix CAPTURE
# RUN: %lldb -b -o 'reproducer status' --capture | FileCheck %s --check-prefix CAPTURE
# RUN: LLDB_CAPTURE_REPRODUCER=1 %lldb -b -o 'reproducer status' | FileCheck %s --check-prefix CAPTURE
# RUN: LLDB_CAPTURE_REPRODUCER=ON %lldb -b -o 'reproducer status' | FileCheck %s --check-prefix CAPTURE
# RUN: LLDB_CAPTURE_REPRODUCER=on %lldb -b -o 'reproducer status' | FileCheck %s --check-prefix CAPTURE
# RUN: LLDB_CAPTURE_REPRODUCER=0 %lldb -b -o 'reproducer status' --capture --capture-path %t.repro | FileCheck %s --check-prefix OFF
# RUN: LLDB_CAPTURE_REPRODUCER=0 %lldb -b -o 'reproducer status' --capture | FileCheck %s --check-prefix OFF
# RUN: LLDB_CAPTURE_REPRODUCER=OFF %lldb -b -o 'reproducer status' --capture --capture-path %t.repro | FileCheck %s --check-prefix OFF
# RUN: LLDB_CAPTURE_REPRODUCER=off %lldb -b -o 'reproducer status' --capture | FileCheck %s --check-prefix OFF
# RUN: LLDB_CAPTURE_REPRODUCER=bogus %lldb -b -o 'reproducer status' --capture | FileCheck %s --check-prefix CAPTURE
# RUN: LLDB_CAPTURE_REPRODUCER=bogus %lldb -b -o 'reproducer status' | FileCheck %s --check-prefix OFF
# CAPTURE: Reproducer is in capture mode.
# OFF: Reproducer is off.

1
lldb/test/Shell/Reproducer/lit.local.cfg
View File

@ -1,2 +1,3 @@
# Enable crash reports for the reproducer tests.
del config.environment['LLVM_DISABLE_CRASH_REPORT']
del config.environment['LLDB_CAPTURE_REPRODUCER']