Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2025-01-11 10:26:44 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[ARM][Thumb2InstrInfo] Fix default 0 opcode when rewriting frame indices

Browse Source 
The static functions `positiveOffsetOpcode`, `negativeOffsetOpcode` and
`immediateOffsetOpcode` (lib/Target/ARM/Thumb2InstrInfo.cpp) currently can
return `0` as default opcode which is meaningless in this situation.

This patch replaces this default value by llvm_unreachable.

Reviewers: t.p.northover, tellenbach

Reviewed By: tellenbach

Subscribers: tellenbach, kristof.beyls, hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D69432

Patch By: Lorenzo Casalino <lorenzo.casalino93@gmail.com>
This commit is contained in:
David Tellenbach 2019-10-28 18:57:53 +00:00
parent e59f7488c7
commit e3a45a24d1
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
llvm/lib/Target/ARM/Thumb2InstrInfo.cpp
View File

@ -388,10 +388,8 @@ negativeOffsetOpcode(unsigned opcode)
return opcode;
default:
break;
llvm_unreachable("unknown thumb2 opcode.");
}
return 0;
}
static unsigned
@ -420,10 +418,8 @@ positiveOffsetOpcode(unsigned opcode)
return opcode;
default:
break;
llvm_unreachable("unknown thumb2 opcode.");
}
return 0;
}
static unsigned
@ -461,10 +457,8 @@ immediateOffsetOpcode(unsigned opcode)
return opcode;
default:
break;
llvm_unreachable("unknown thumb2 opcode.");
}
return 0;
}
bool llvm::rewriteT2FrameIndex(MachineInstr &MI, unsigned FrameRegIdx,