Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2024-11-27 07:31:28 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[analyzer][NFC] Simplify BugType handling in core.BitwiseShift (#74609)

Browse Source 
Eliminate the `mutable unique_ptr` hack because it's no longer needed.
(This cleanup could be done anywhere, I'm doing it here now because it
was me who published this checker with the old hack when it was already
superfluous.)
This commit is contained in:
DonatNagyE 2023-12-07 10:23:19 +01:00 committed by GitHub
parent b768b39342
commit e4c7ee3c44
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
clang/lib/StaticAnalyzer/Checkers/BitwiseShiftChecker.cpp
View File

@ -344,7 +344,7 @@ BitwiseShiftValidator::createBugReport(StringRef ShortMsg, StringRef Msg) const
} // anonymous namespace
class BitwiseShiftChecker : public Checker<check::PreStmt<BinaryOperator>> {
mutable std::unique_ptr<BugType> BTPtr;
BugType BT{this, "Bitwise shift", "Suspicious operation"};
public:
void checkPreStmt(const BinaryOperator *B, CheckerContext &Ctx) const {
@ -353,11 +353,7 @@ public:
if (Op != BO_Shl && Op != BO_Shr)
return;
if (!BTPtr)
BTPtr = std::make_unique<BugType>(this, "Bitwise shift",
"Suspicious operation");
BitwiseShiftValidator(B, Ctx, *BTPtr, Pedantic).run();
BitwiseShiftValidator(B, Ctx, BT, Pedantic).run();
}
bool Pedantic = false;