Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2024-11-28 16:11:29 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

Browse Source 
If we want to export all lldb symbols (i.e LLDB_EXPORT_ALL_SYMBOLS=ON), we need to use default visibility for all LLDB libraries even if a global CMAKE_CXX_VISIBILITY_PRESET=hidden is present. In fact, there are cases in which a global llvm configuration wants CMAKE_CXX_VISIBILITY_PRESET as hidden but simultaneously LLDB_EXPORT_ALL_SYMBOLS=ON is also needed to be able to develop out-of-tree lldb plugins.

Differential Revision: https://reviews.llvm.org/D147453
This commit is contained in:
walter erquinigo 2023-04-03 11:32:53 -05:00
parent 64549f0903
commit e538c6fc30
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lldb/cmake/modules/AddLLDB.cmake
View File

@ -165,6 +165,13 @@ function(add_lldb_library name)
else()
set_target_properties(${name} PROPERTIES FOLDER "lldb libraries")
endif()
# If we want to export all lldb symbols (i.e LLDB_EXPORT_ALL_SYMBOLS=ON), we
# need to use default visibility for all LLDB libraries even if a global
# `CMAKE_CXX_VISIBILITY_PRESET=hidden`is present.
if (LLDB_EXPORT_ALL_SYMBOLS)
set_target_properties(${name} PROPERTIES CXX_VISIBILITY_PRESET default)
endif()
endfunction(add_lldb_library)
function(add_lldb_executable name)