diff --git a/clang/lib/Sema/SemaStmtAttr.cpp b/clang/lib/Sema/SemaStmtAttr.cpp index 6d443837a4c5..eeef85373ccb 100644 --- a/clang/lib/Sema/SemaStmtAttr.cpp +++ b/clang/lib/Sema/SemaStmtAttr.cpp @@ -233,7 +233,8 @@ static Attr *handleNoInlineAttr(Sema &S, Stmt *St, const ParsedAttr &A, for (const auto *CallExpr : CEF.getCallExprs()) { const Decl *Decl = CallExpr->getCalleeDecl(); - if (Decl->hasAttr() || Decl->hasAttr()) + if (Decl && + (Decl->hasAttr() || Decl->hasAttr())) S.Diag(St->getBeginLoc(), diag::warn_function_stmt_attribute_precedence) << A << (Decl->hasAttr() ? 0 : 1); } @@ -259,7 +260,7 @@ static Attr *handleAlwaysInlineAttr(Sema &S, Stmt *St, const ParsedAttr &A, for (const auto *CallExpr : CEF.getCallExprs()) { const Decl *Decl = CallExpr->getCalleeDecl(); - if (Decl->hasAttr() || Decl->hasAttr()) + if (Decl && (Decl->hasAttr() || Decl->hasAttr())) S.Diag(St->getBeginLoc(), diag::warn_function_stmt_attribute_precedence) << A << (Decl->hasAttr() ? 2 : 1); } diff --git a/clang/test/Sema/attr-alwaysinline.cpp b/clang/test/Sema/attr-alwaysinline.cpp index 6b8e8f215a4b..be3f74c8bfa9 100644 --- a/clang/test/Sema/attr-alwaysinline.cpp +++ b/clang/test/Sema/attr-alwaysinline.cpp @@ -25,3 +25,16 @@ void foo() { } [[clang::always_inline]] static int i = bar(); // expected-warning {{'always_inline' attribute only applies to functions and statements}} + +// This used to crash the compiler. +template +int foo(int x) { + [[clang::always_inline]] return foo(x + 1); +} + +// FIXME: This should warn that always_inline statement attribute has higher +// precedence than the noinline function attribute. +template [[gnu::noinline]] +int bar(int x) { + [[clang::always_inline]] return bar(x + 1); +} diff --git a/clang/test/Sema/attr-noinline.cpp b/clang/test/Sema/attr-noinline.cpp index d35782f11adb..ae0f80ca296e 100644 --- a/clang/test/Sema/attr-noinline.cpp +++ b/clang/test/Sema/attr-noinline.cpp @@ -25,3 +25,16 @@ void foo() { } [[clang::noinline]] static int i = bar(); // expected-warning {{'noinline' attribute only applies to functions and statements}} + +// This used to crash the compiler. +template +int foo(int x) { + [[clang::noinline]] return foo(x + 1); +} + +// FIXME: This should warn that noinline statement attribute has higher +// precedence than the always_inline function attribute. +template [[clang::always_inline]] +int bar(int x) { + [[clang::noinline]] return bar(x + 1); +}