diff --git a/bolt/include/bolt/Profile/YAMLProfileReader.h b/bolt/include/bolt/Profile/YAMLProfileReader.h index f6e602166329..f7cb52e151b6 100644 --- a/bolt/include/bolt/Profile/YAMLProfileReader.h +++ b/bolt/include/bolt/Profile/YAMLProfileReader.h @@ -51,17 +51,17 @@ private: /// Map a function ID from a YAML profile to a BinaryFunction object. std::vector YamlProfileToFunction; + using FunctionSet = std::unordered_set; /// To keep track of functions that have a matched profile before the profile /// is attributed. - std::unordered_set ProfiledFunctions; + FunctionSet ProfiledFunctions; /// For LTO symbol resolution. /// Map a common LTO prefix to a list of YAML profiles matching the prefix. StringMap> LTOCommonNameMap; /// Map a common LTO prefix to a set of binary functions. - StringMap> - LTOCommonNameFunctionMap; + StringMap LTOCommonNameFunctionMap; /// Strict matching of a name in a profile to its contents. StringMap ProfileNameToProfile; diff --git a/bolt/lib/Profile/YAMLProfileReader.cpp b/bolt/lib/Profile/YAMLProfileReader.cpp index 90e43b402750..54e468f0759a 100644 --- a/bolt/lib/Profile/YAMLProfileReader.cpp +++ b/bolt/lib/Profile/YAMLProfileReader.cpp @@ -36,13 +36,12 @@ namespace llvm { namespace bolt { bool YAMLProfileReader::isYAML(const StringRef Filename) { - ErrorOr> MB = - MemoryBuffer::getFileOrSTDIN(Filename); - if (std::error_code EC = MB.getError()) - report_error(Filename, EC); - StringRef Buffer = MB.get()->getBuffer(); - if (Buffer.startswith("---\n")) - return true; + if (auto MB = MemoryBuffer::getFileOrSTDIN(Filename)) { + StringRef Buffer = (*MB)->getBuffer(); + return Buffer.startswith("---\n"); + } else { + report_error(Filename, MB.getError()); + } return false; } @@ -66,13 +65,9 @@ void YAMLProfileReader::buildNameMaps( } bool YAMLProfileReader::hasLocalsWithFileName() const { - for (const StringMapEntry &KV : - ProfileNameToProfile) { - const StringRef &FuncName = KV.getKey(); - if (FuncName.count('/') == 2 && FuncName[0] != '/') - return true; - } - return false; + return llvm::any_of(ProfileNameToProfile.keys(), [](StringRef FuncName) { + return FuncName.count('/') == 2 && FuncName[0] != '/'; + }); } bool YAMLProfileReader::parseFunctionProfile( @@ -327,12 +322,9 @@ Error YAMLProfileReader::readProfile(BinaryContext &BC) { auto profileMatches = [](const yaml::bolt::BinaryFunctionProfile &Profile, BinaryFunction &BF) { - if (opts::IgnoreHash && Profile.NumBasicBlocks == BF.size()) - return true; - if (!opts::IgnoreHash && - Profile.Hash == static_cast(BF.getHash())) - return true; - return false; + if (opts::IgnoreHash) + return Profile.NumBasicBlocks == BF.size(); + return Profile.Hash == static_cast(BF.getHash()); }; // We have to do 2 passes since LTO introduces an ambiguity in function