From eb7f2315f4e73b689e5423a2d14b109be5cbc821 Mon Sep 17 00:00:00 2001 From: Matt Kopec Date: Wed, 26 Jun 2013 18:46:08 +0000 Subject: [PATCH] Remove unneeded limbo state flag. llvm-svn: 185010 --- .../source/Plugins/Process/POSIX/ProcessPOSIX.cpp | 15 ++------------- lldb/source/Plugins/Process/POSIX/ProcessPOSIX.h | 7 ------- 2 files changed, 2 insertions(+), 20 deletions(-) diff --git a/lldb/source/Plugins/Process/POSIX/ProcessPOSIX.cpp b/lldb/source/Plugins/Process/POSIX/ProcessPOSIX.cpp index 32dfdd74aa7f..1f33013f4da3 100644 --- a/lldb/source/Plugins/Process/POSIX/ProcessPOSIX.cpp +++ b/lldb/source/Plugins/Process/POSIX/ProcessPOSIX.cpp @@ -76,7 +76,6 @@ ProcessPOSIX::ProcessPOSIX(Target& target, Listener &listener) m_monitor(NULL), m_module(NULL), m_message_mutex (Mutex::eMutexTypeRecursive), - m_in_limbo(false), m_exit_now(false) { // FIXME: Putting this code in the ctor and saving the byte order in a @@ -257,18 +256,9 @@ ProcessPOSIX::DoResume() { StateType state = GetPrivateState(); - assert(state == eStateStopped || state == eStateCrashed); + assert(state == eStateStopped); - // We are about to resume a thread that will cause the process to exit so - // set our exit status now. Do not change our state if the inferior - // crashed. - if (state == eStateStopped) - { - if (m_in_limbo) - SetExitStatus(m_exit_status, NULL); - else - SetPrivateState(eStateRunning); - } + SetPrivateState(eStateRunning); bool did_resume = false; uint32_t thread_count = m_thread_list.GetSize(false); @@ -395,7 +385,6 @@ ProcessPOSIX::SendMessage(const ProcessMessage &message) thread->SetState(eStateStopped); if (message.GetTID() == GetID()) { - m_in_limbo = true; m_exit_status = message.GetExitStatus(); if (m_exit_now) { diff --git a/lldb/source/Plugins/Process/POSIX/ProcessPOSIX.h b/lldb/source/Plugins/Process/POSIX/ProcessPOSIX.h index b540805d4967..8402aad3496b 100644 --- a/lldb/source/Plugins/Process/POSIX/ProcessPOSIX.h +++ b/lldb/source/Plugins/Process/POSIX/ProcessPOSIX.h @@ -171,13 +171,6 @@ protected: lldb_private::Mutex m_message_mutex; std::queue m_message_queue; - /// True when the process has entered a state of "limbo". - /// - /// This flag qualifies eStateStopped. It lets us know that when we - /// continue from this state the process will exit. Also, when true, - /// Process::m_exit_status is set. - bool m_in_limbo; - /// Drive any exit events to completion. bool m_exit_now;