From f7643f8da3fb2ccfbe8eb8a9a6c14b4ddf6eb60f Mon Sep 17 00:00:00 2001
From: Amir Ayupov <aaupov@fb.com>
Date: Wed, 3 May 2023 16:40:29 -0700
Subject: [PATCH] [BOLT] Remove redundant dumps in AsmDump

Dumping jump table and tail call fdata is covered by subsequent iteration over
successors.

Reviewed By: #bolt, maksfb

Differential Revision: https://reviews.llvm.org/D149799
---
 bolt/lib/Passes/AsmDump.cpp | 34 ----------------------------------
 1 file changed, 34 deletions(-)

diff --git a/bolt/lib/Passes/AsmDump.cpp b/bolt/lib/Passes/AsmDump.cpp
index c163345fe7f2..18d0395cbc4a 100644
--- a/bolt/lib/Passes/AsmDump.cpp
+++ b/bolt/lib/Passes/AsmDump.cpp
@@ -55,34 +55,6 @@ void dumpCFI(const BinaryFunction &BF, const MCInst &Instr, AsmPrinter &MAP) {
   }
 }
 
-void dumpJumpTableFdata(raw_ostream &OS, const BinaryFunction &BF,
-                        const MCInst &Instr, const std::string &BranchLabel) {
-  StringRef FunctionName = BF.getOneName();
-  const JumpTable *JT = BF.getJumpTable(Instr);
-  for (uint32_t i = 0; i < JT->Entries.size(); ++i) {
-    StringRef TargetName = JT->Entries[i]->getName();
-    const uint64_t Mispreds = JT->Counts[i].Mispreds;
-    const uint64_t Count = JT->Counts[i].Count;
-    OS << "# FDATA: 1 " << FunctionName << " #" << BranchLabel << "# "
-       << "1 " << FunctionName << " #" << TargetName << "# " << Mispreds << " "
-       << Count << '\n';
-  }
-}
-
-void dumpTailCallFdata(raw_ostream &OS, const BinaryFunction &BF,
-                       const MCInst &Instr, const std::string &BranchLabel) {
-  const BinaryContext &BC = BF.getBinaryContext();
-  StringRef FunctionName = BF.getOneName();
-  auto CallFreq = BC.MIB->getAnnotationWithDefault<uint64_t>(Instr, "Count");
-  const MCSymbol *Target = BC.MIB->getTargetSymbol(Instr);
-  const BinaryFunction *TargetBF = BC.getFunctionForSymbol(Target);
-  if (!TargetBF)
-    return;
-  OS << "# FDATA: 1 " << FunctionName << " #" << BranchLabel << "# "
-     << "1 " << TargetBF->getPrintName() << " 0 "
-     << "0 " << CallFreq << '\n';
-}
-
 void dumpTargetFunctionStub(raw_ostream &OS, const BinaryContext &BC,
                             const MCSymbol *CalleeSymb,
                             const BinarySection *&LastCS) {
@@ -230,12 +202,6 @@ void dumpFunction(const BinaryFunction &BF) {
 
       BC.InstPrinter->printInst(&Instr, 0, "", *BC.STI, OS);
       OS << '\n';
-
-      // Dump profile data in FDATA format (as parsed by link_fdata).
-      if (BC.MIB->getJumpTable(Instr))
-        dumpJumpTableFdata(OS, BF, Instr, BranchLabel);
-      else if (BC.MIB->isTailCall(Instr))
-        dumpTailCallFdata(OS, BF, Instr, BranchLabel);
     }
 
     // Dump profile data in FDATA format (as parsed by link_fdata).