Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2025-04-03 05:32:24 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Avoid implementation defined behavior in a test.

Browse Source 
Summary:
num_put::put uses %p for pointer types, but the exact format of %p is
implementation defined behavior for the C library. Compare output to
snprintf for portability.

Reviewers: EricWF, mclow.lists

Reviewed By: EricWF

Subscribers: cfe-commits

Differential Revision: https://reviews.llvm.org/D29197

llvm-svn: 293926
This commit is contained in:
Dan Albert 2017-02-02 19:44:11 +00:00
parent d67ab623f6
commit f9dc6670bc
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_pointer.pass.cpp
View File

@ -38,6 +38,12 @@ int main()
char str[50];
output_iterator<char*> iter = f.put(output_iterator<char*>(str), ios, '*', v);
std::string ex(str, iter.base());
assert(ex == "0x0" || ex == "(nil)");
char expected_str[32] = {};
// num_put::put uses %p for pointer types, but the exact format of %p is
// implementation defined behavior for the C library. Compare output to
// snprintf for portability.
int rc = snprintf(expected_str, sizeof(expected_str), "%p", v);
assert(rc > 0);
assert(ex == expected_str);
}
}