Commit Graph

3 Commits

Author SHA1 Message Date
Richard Smith
dd37b5a35b PR46997: don't run clang-format on clang's testcases.
The formatting of the testcases matters and shouldn't be overwritten by
a tool.
2020-08-04 17:53:25 -07:00
Reid Kleckner
efd1f17cd9 Fix .arclint on Windows
Run "bash myscript.sh". This will work if bash is on PATH, which it
probably is, since developers have to use git.

Reviewed By: scott.linder

Differential Revision: https://reviews.llvm.org/D78846
2020-04-28 09:55:48 -07:00
Siddhartha Bagaria
3c371491a2 Setup clang-format as an Arcanist linter
Summary:
This uses clang-format-diff as a linter for Arcanist.

`arc lint` flow, also run as part of `arc diff` unless skipped with
`--nolint`, will now run the linter shell script on the changed files,
and prompt the user to accept the suggested changes.

Message when clang-format-diff is not installed:
{F6654094}

Example of the noise during code review when clang-format-diff is not installed:
https://reviews.llvm.org/differential/changeset/?ref=1115809

Prompt when clang-format-diff is installed and suggests edits:
{F6650223}

Reviewers: probinson, scott.linder

Reviewed By: scott.linder

Subscribers: scott.linder, MyDeveloperDay, JonasToth, danilaml, JDevlieghere, dberris, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D49116
2020-03-30 15:02:33 -04:00